Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix key nav on sidenav #13177

Merged
merged 1 commit into from
Jan 24, 2025
Merged

Conversation

aalves08
Copy link
Member

@aalves08 aalves08 commented Jan 22, 2025

Summary

Fixes #12780

Occurred changes and/or fixed issues

  • Fixes keyboard navigation on the SideNav component
  • Update LocaleSelector to remove special implementation on SideNav and reuse the LocaleSelector component

Technical notes summary

Areas or cases that should be tested

Areas which could experience regressions

Screenshot/Video

Screen.Recording.2025-01-21.at.11.44.14.mov

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

@aalves08 aalves08 self-assigned this Jan 22, 2025
@aalves08 aalves08 added this to the v2.11.0 milestone Jan 22, 2025
@aalves08 aalves08 requested a review from rak-phillip January 22, 2025 11:13
@aalves08 aalves08 changed the title add key nav to sidenav fix key nav on sidenav Jan 22, 2025
@aalves08 aalves08 force-pushed the 12780-key-nav-sidenav branch from 5b45801 to 1d78a5b Compare January 23, 2025 13:56
Copy link
Member

@rak-phillip rak-phillip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - good call on the locale selector!

@aalves08 aalves08 force-pushed the 12780-key-nav-sidenav branch from 1d78a5b to 4b99489 Compare January 24, 2025 09:42
@aalves08 aalves08 merged commit 51bdc52 into rancher:master Jan 24, 2025
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

a11y: Fix keyboard navigation, role, aria-labels and focus display issues on the side navigation component
2 participants