Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing include in CMake config #264

Closed
wants to merge 1 commit into from

Conversation

asmorkalov
Copy link

Missing include leads to error:

$ cmake -DSPNG_DIR=/home/alexander/Projects/libspng-0.7.4/build/install/lib/cmake/spng/ ../src/
-- The C compiler identification is GNU 9.4.0
-- The CXX compiler identification is GNU 9.4.0
-- Check for working C compiler: /usr/bin/cc
-- Check for working C compiler: /usr/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Check for working CXX compiler: /usr/bin/c++
-- Check for working CXX compiler: /usr/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
CMake Error at /home/alexander/Projects/libspng-0.7.4/build/install/lib/cmake/spng/SPNGConfig.cmake:27 (find_dependency):
  Unknown CMake command "find_dependency".
Call Stack (most recent call first):
  CMakeLists.txt:5 (find_package)


-- Configuring incomplete, errors occurred!
See also "/home/alexander/tmp/opencv-repro/build/CMakeFiles/CMakeOutput.log".

asmorkalov added a commit to opencv/opencv that referenced this pull request Dec 20, 2023
Add support for external libspng. #24718

Fixes #24683
Related patch to libspng: randy408/libspng#264

### Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

- [x] I agree to contribute to the project under Apache 2 License.
- [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
- [x] The PR is proposed to the proper branch
- [x] There is a reference to the original bug report and related work
- [ ] There is accuracy test, performance test and test data in opencv_extra repository, if applicable
      Patch to opencv_extra has the same branch name.
- [ ] The feature is well documented and sample code can be built with the project CMake
@randy408
Copy link
Owner

An identical fix has been merged (#262) and will ship in the next version in 1-2 months.

@randy408 randy408 closed this Dec 20, 2023
thewoz pushed a commit to thewoz/opencv that referenced this pull request May 29, 2024
Add support for external libspng. opencv#24718

Fixes opencv#24683
Related patch to libspng: randy408/libspng#264

### Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

- [x] I agree to contribute to the project under Apache 2 License.
- [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
- [x] The PR is proposed to the proper branch
- [x] There is a reference to the original bug report and related work
- [ ] There is accuracy test, performance test and test data in opencv_extra repository, if applicable
      Patch to opencv_extra has the same branch name.
- [ ] The feature is well documented and sample code can be built with the project CMake
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants