Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nsfw link in mssql_clr_payload, and rubocop the module #19798

Merged
merged 2 commits into from
Jan 15, 2025

Conversation

h00die
Copy link
Contributor

@h00die h00die commented Jan 10, 2025

fixes #19797

Replaces a now NSFW link with a wayback link. Apparently rubocop also ran :)

@bcoles
Copy link
Contributor

bcoles commented Jan 10, 2025

This module is based on the work that was done by @leechristensen and @sekirkity as documented [here](http://sekirkity.com/command-execution-in-sql-server-via-fileless-clr-based-custom-stored-procedure/).

@msutovsky-r7 msutovsky-r7 self-assigned this Jan 10, 2025
Copy link
Contributor

@msutovsky-r7 msutovsky-r7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@msutovsky-r7
Copy link
Contributor

Hi @h00die, I would probably rename PR as it's also little bit of code refactoring, so just to have it consistently

@msutovsky-r7 msutovsky-r7 added the code quality Improving code quality label Jan 10, 2025
@h00die h00die changed the title fix nsfw link in module Fix nsfw link in mssql_clr_payload, and rubocop the module Jan 11, 2025
@bcoles
Copy link
Contributor

bcoles commented Jan 11, 2025

Hi @h00die, I would probably rename PR as it's also little bit of code refactoring, so just to have it consistently

A reminder that this would be a non-issue if we could run rubocop -a over the entire code base in a single PR, which is blocked by requiring all modules to have Notes (#17582).

@msutovsky-r7 msutovsky-r7 merged commit 0630187 into rapid7:master Jan 15, 2025
41 checks passed
@h00die h00die deleted the bad_link branch January 15, 2025 21:05
@bwatters-r7 bwatters-r7 added the rn-no-release-notes no release notes label Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality Improving code quality rn-no-release-notes no release notes
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Dead link, don't go to References URL anymore, it's NSFW anymore
4 participants