Carry on if the record can't be cached #19800
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an exception when a custom DNS resolver is used that was preventing SRV records from resolving correctly. Only some records can be cached by DNS, and if a record that isn't compatible is added to the cache, an exception is raised. The caller should ignore the exception if they have the answer they require and just continue with it.
metasploit-framework/lib/rex/proto/dns/cache.rb
Line 48 in 8344c2c
This came up while using the functionality added in #18446 that uses DNS to lookup SRV records. SRV records can't be cached and the exception was preventing the data from being returned at all.
Testing Steps
dns