return empty html document if custom var grafana_graph_disable is set #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Old community link show 404 'Page not found' - Copy current requirements from documentation
…tead of `Icinga\Module\Graphite\ProvidedHook\Icingadb\IcingadbSupport`
Fix the object relations and assign `$object` to `$this->object` in `IcingaDbGrapher::getPreviewHtml()`
Update community link and requirements in README
Fix URLs for v1.3.6 in CHANGELOG.md
remove cache control headers, fix is needed for them
raviks789
force-pushed
the
feature/icingadb-support
branch
from
e9c50ee to
1112107
Compare
raviks789
force-pushed
the
feature/icingadb-support
branch
from
1404378 to
535cf21
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if the custom variable grafana_graph_disable is set, an empty HTML document is returned so that no graph is displayed in the web interface.
Also changed
'service' => rawurlencode($serviceName)to'service' => $serviceNameso that the Services link is created correctly with spaces in the name, as noted by @fabbricalox here:Mikesch-mp#288 (comment)