[core] Use statusor for filesystem and resolve dependency #50029
+123
−66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dentiny
force-pushed
the
hjiang/filesystem-statusor
branch
from
15d7c05 to
f51d822
Compare
Signed-off-by: dentiny <[email protected]>
dentiny
force-pushed
the
hjiang/filesystem-statusor
branch
from
f51d822 to
2d55e3c
Compare
Signed-off-by: dentiny <[email protected]>
dentiny
commented
Jan 23, 2025
| @@ -367,7 +367,7 @@ void RayLog::InitLogFormat() { | |||
| app_name_without_path = "DefaultApp"; | |||
| } else { | |||
| // Find the app name without the path. | |||
| std::string app_file_name = ray::GetFileName(app_name); | |||
| std::string app_file_name = std::filesystem::path(app_name).filename().string(); | |||
There was a problem hiding this comment.
To reduce circular dependency between logging and filesystem.
Signed-off-by: dentiny <[email protected]>
rynewang
reviewed
Jan 23, 2025
Signed-off-by: dentiny <[email protected]>
|
Signed-off-by: dentiny <[email protected]>
jjyao
approved these changes
Jan 25, 2025
|
Failed unit tests should have nothing to do with my change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address @jjyao 's comment to use
StatusOrto read all content for the given file.Also cleanup dependency for ray utils, otherwise we have circular dependency among status, logging, filesystem and utils.