Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Game Visibility And Add Public Rooms Panel on Front Page #423

Merged
merged 6 commits into from
Mar 1, 2023
Merged

Implement Game Visibility And Add Public Rooms Panel on Front Page #423

merged 6 commits into from
Mar 1, 2023

Conversation

jimmyfang94
Copy link
Contributor

First pass at: #49

  • Added a GameVisibility field. Defaults to unlisted, but can be toggled to public. In the future can be used for private games, etc.
  • Added a PublicRoomsPane, with functionality to poll a new API that returns all public games and displays them on the first page. Is polled on first render, and then has a refresh button for ad hoc refreshes afterwards.

Screen Shot 2023-02-24 at 3 34 01 PM

Screen Shot 2023-02-24 at 3 34 12 PM

rbtying
rbtying requested changes Feb 25, 2023
View reviewed changes
Copy link
Owner

@rbtying rbtying left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice work, and thank you again for working on this!

Left some comments inline, but this is pretty close!

backend/src/state_dump.rs Outdated Show resolved Hide resolved
backend/src/state_dump.rs Outdated Show resolved Hide resolved
frontend/src/Initialize.tsx Show resolved Hide resolved
@jimmyfang94 jimmyfang94 requested a review from rbtying February 26, 2023 05:31
@jimmyfang94 jimmyfang94 force-pushed the implement-public-rooms branch from 0a00500 to 063d213 Compare February 26, 2023 05:40
rbtying
rbtying reviewed Feb 26, 2023
View reviewed changes
Copy link
Owner

@rbtying rbtying left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is looking really good. I'd add a changelog update (in Credits.tsx) so people know about the new feature :)

backend/src/state_dump.rs Show resolved Hide resolved
backend/src/state_dump.rs Outdated Show resolved Hide resolved
frontend/src/PublicRoomsPane.tsx Outdated Show resolved Hide resolved
@jimmyfang94 jimmyfang94 requested a review from rbtying February 26, 2023 08:21
@jimmyfang94
Copy link
Contributor Author

thanks for the speedy replies! first time playing with rust, fun learning exp

@jimmyfang94 jimmyfang94 force-pushed the implement-public-rooms branch from 62909c1 to 491c724 Compare February 26, 2023 08:44
@rbtying rbtying merged commit 91dca63 into rbtying:master Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rbtying rbtying rbtying approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jimmyfang94 @rbtying