Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: drop support for python 3.8 #1213

Merged
merged 2 commits into from
Jan 9, 2025
Merged

feat: drop support for python 3.8 #1213

merged 2 commits into from
Jan 9, 2025

Conversation

afuetterer
Copy link
Member

Description

Related issue: #1030

@afuetterer
Copy link
Member Author

I did not touch the files, that pre-commit is complaining about. What is happening?

@afuetterer
Copy link
Member Author

An observation: Is the lint step in ci still needed with pre-commit.ci enabled?

@MyPyDavid
Copy link
Member

An observation: Is the lint step in ci still needed with pre-commit.ci enabled?

that pre-commit.ci is currently only still in the dependency-updates enabled (#1154)
Maybe this PR should be branched off and merged into dependency-updates?

those linting errors actually make sense, since those typing errors only apply from 3.9 on,
(https://docs.astral.sh/ruff/rules/non-pep585-annotation/, https://peps.python.org/pep-0585/ )

However, I think that I should fix those typing linting errors since I started adding typing to my features..
Think it's better to make this PR target to dependency-updates and fix the linting errors there.

@afuetterer
Copy link
Member Author

Interesting. I will switch the target branch then.

@afuetterer afuetterer changed the base branch from 2.3.0 to dependency-updates December 9, 2024 08:42
@afuetterer
Copy link
Member Author

Done.

@MyPyDavid MyPyDavid self-assigned this Dec 9, 2024
@MyPyDavid MyPyDavid added this to the RDMO 2.3.0 milestone Dec 9, 2024
@jochenklar
Copy link
Member

Cool thanks, but lets merge this after all the interview branches.

@MyPyDavid
Copy link
Member

it would go first to the dependency-updates anyway and the dependency-updates will go after the interview

MyPyDavid
MyPyDavid approved these changes Jan 8, 2025
View reviewed changes
Copy link
Member

@MyPyDavid MyPyDavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

think it's good to go for in rdmorganiser:dependency-updates

jochenklar
jochenklar approved these changes Jan 9, 2025
View reviewed changes
Copy link
Member

@jochenklar jochenklar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MyPyDavid MyPyDavid merged commit 8ee84d1 into rdmorganiser:dependency-updates Jan 9, 2025
19 checks passed
@afuetterer afuetterer deleted the 1030-drop-python-38 branch January 9, 2025 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MyPyDavid MyPyDavid MyPyDavid approved these changes

@jochenklar jochenklar jochenklar approved these changes

Assignees

@MyPyDavid MyPyDavid

Labels
type:maintenance
Projects
None yet
Milestone
RDMO 2.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@afuetterer @MyPyDavid @jochenklar