gulp fixes and reverts #542
Conversation
| @@ -51,12 +51,6 @@ app.use helmet.nocache() | |||
| # ensure all assets and data are compressed - above static | |||
| app.use compress() | |||
|
|
|||
There was a problem hiding this comment.
Killed dep as @zacronos mentioned.. this was not needed
|
@zacronos @realtyjustin @jessecstewart looking for 2 LGTMS |
| @@ -13,13 +13,5 @@ gulp.task 'watch_all_front', gulp.parallel 'angularWatch', 'angularWatchAdmin' | |||
| gulp.task 'watch', gulp.series 'watch_all_front', (done) -> | |||
| gulp.watch ['gulp/**/*.coffee','spec/gulp/**/*.coffee', specCommon], gulp.series 'gulpSpec' | |||
| gulp.watch ['backend/**/*.coffee', 'spec/backend/**/*.coffee', specCommon], gulp.series 'backendSpec' | |||
There was a problem hiding this comment.
Removed
paths.destFull.scripts + '/map.bundle.js',
- paths.destFull.scripts + '/map.templates.js',
- paths.destFull.scripts + '/admin.bundle.js',
- paths.destFull.scripts + '/admin.templates.js',
because this is an artifact and it should not be watched. This was causing extra build times and and re-kicking the build as files were being moved and shuffled by gulp. We don't need to watch the artifacts we need to watch the frontend stuff which we are already doing via watch_all_front .
Eliminating this also eliminates the need to have watch run at a specific time. Heck it could even be added to be prior to clean via parallel.
There was a problem hiding this comment.
This was my bad, I listed the artifacts so when they were rebuilt, Karma would run specs. But looking at the Karma docs it looks like it watches everything configured within files by default (http://karma-runner.github.io/0.8/config/files.html). That does make me wonder why Karma wasn't triggering twice each time though.. am I understanding this correctly @nmccready ?
There was a problem hiding this comment.
The watch inside karma itself is off so all watching is done by gulp. This is done to avoid complications.
There was a problem hiding this comment.
In that case, will specs still run on a rebuild?
|
LGTM |
|
|
||
| gulp.task 'developNoSpec', gulp.series 'clean', 'otherAssets', gulp.parallel('express', 'watch') | ||
| #this allows `gulp help` task to work which will display all taks via CLI so yes it is used |
There was a problem hiding this comment.
notes on gulp-help
chmontgomery/gulp-help#31
|
Confirmed the admin.css and admin.templates.js are being build as expected, as well as watches on common and admin seem to rebuild upon file update as expected as well, too - thx for fixing those |
So bottom line I am not sure why everything was dandy Friday. Anyways things are back to working order. The build times are not as glorious as Friday, but that could be due to more admin files.