Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support env variables to run Codeflare and Codeflare-SDK tests … #1815

Draft
wants to merge 1 commit into
base: releases/2.13.0
Choose a base branch
from
Draft

Added support env variables to run Codeflare and Codeflare-SDK tests … #1815

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion ods_ci/tests/Resources/Page/DistributedWorkloads/DistributedWorkloads.resource
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,21 @@

*** Variables ***
${VIRTUAL_ENV_NAME} venv3.9
${CODEFLARE-SDK-RELEASE-TAG} v0.19.1
${CODEFLARE-SDK-API_URL} %{CODEFLARE-SDK-API_URL=https://api.github.com/repos/project-codeflare/codeflare-sdk/releases/173851082}
${CODEFLARE-SDK_DIR} codeflare-sdk
${CODEFLARE-SDK_REPO_URL} %{CODEFLARE-SDK_REPO_URL=https://github.com/project-codeflare/codeflare-sdk.git}
${DISTRIBUTED_WORKLOADS_RELEASE_ASSETS} https://github.com/opendatahub-io/distributed-workloads/releases/download/v2.13.1
${RAY_IMAGE} quay.io/rhoai/ray@sha256:859f5c41d41bad1935bce455ad3732dff9d4d4c342b7155a7cd23809e85698ab

Check warning

Code scanning / Robocop

Line is too long ({{ line_length }}/{{ allowed_length }}) Warning test

Line is too long (130/120)
${FMS_HF_TUNING_IMAGE} quay.io/modh/fms-hf-tuning@sha256:eee08ba5bb14ead4e031408fcb2334d8da817dec3be7df8d2fc8b1a3d3bb9c1d
${KFTO_CORE_BINARY_NAME} kfto
${KFTO_UPGRADE_BINARY_NAME} kfto-upgrade
${PIP_INDEX_URL} ${PIP_INDEX_URL}
${PIP_TRUSTED_HOST} ${PIP_TRUSTED_HOST}
${AWS_DEFAULT_ENDPOINT} ${S3.BUCKET_5.ENDPOINT}
${AWS_STORAGE_BUCKET} ${S3.BUCKET_5.NAME}
${AWS_ACCESS_KEY_ID} ${S3.AWS_ACCESS_KEY_ID}
${AWS_SECRET_ACCESS_KEY} ${S3.AWS_SECRET_ACCESS_KEY}
${AWS_STORAGE_BUCKET_MNIST_DIR} mnist-datasets


*** Keywords ***
Expand Down Expand Up @@ -46,6 +54,14 @@
[Arguments] ${TEST_TYPE} ${TEST_NAME}
Log To Console "Running codeflare-sdk test: ${TEST_NAME}"
${result} = Run Process source ${VIRTUAL_ENV_NAME}/bin/activate && cd ${CODEFLARE-SDK_DIR} && poetry env use 3.9 && poetry install --with test,docs && poetry run pytest -v -s ./tests/${TEST_TYPE}/${TEST_NAME} --timeout\=300 && deactivate
... env:RAY_IMAGE=${RAY_IMAGE}
... env:AWS_DEFAULT_ENDPOINT=${AWS_DEFAULT_ENDPOINT}
... env:AWS_ACCESS_KEY_ID=${AWS_ACCESS_KEY_ID}
... env:AWS_SECRET_ACCESS_KEY=${AWS_SECRET_ACCESS_KEY}
... env:AWS_STORAGE_BUCKET=${AWS_STORAGE_BUCKET}
... env:AWS_STORAGE_BUCKET_MNIST_DIR=${AWS_STORAGE_BUCKET_MNIST_DIR}
... env:PIP_INDEX_URL=${PIP_INDEX_URL}
... env:PIP_TRUSTED_HOST=${PIP_TRUSTED_HOST}
... shell=true
... stderr=STDOUT
Log To Console ${result.stdout}
Expand Down
3 changes: 2 additions & 1 deletion ods_ci/tests/Tests/0600__distributed_workloads/test-run-codeflare-sdk-e2e-tests.robot
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,11 +29,12 @@ Run TestRayLocalInteractiveOauth test
*** Keywords ***
Prepare Codeflare-sdk E2E Test Suite
[Documentation] Prepare codeflare-sdk E2E Test Suite
Log To Console "Restarting kueue"
Restart Kueue
Prepare Codeflare-SDK Test Setup
RHOSi Setup

Teardown Codeflare-sdk E2E Test Suite
[Documentation] Teardown codeflare-sdk E2E Test Suite
Cleanup Codeflare-SDK Setup
RHOSi Teardown

26 changes: 21 additions & 5 deletions ods_ci/tests/Tests/0600__distributed_workloads/test-run-codeflare-tests.robot
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,18 @@


*** Variables ***
${CODEFLARE_RELEASE_ASSETS} %{CODEFLARE_RELEASE_ASSETS=https://github.com/opendatahub-io/distributed-workloads/releases/download/v2.13.1}
${NOTEBOOK_IMAGE} %{NOTEBOOK_IMAGE_STREAM_NAME=quay.io/modh/odh-generic-data-science-notebook@sha256:d81e47fa2f5656042748cf2cd1d97033f58d6dd707667ff0e25aa969959e56a7}
${NOTEBOOK_USER_NAME} ${TEST_USER_3.USERNAME}
${NOTEBOOK_USER_PASSWORD} ${TEST_USER_3.PASSWORD}
${CODEFLARE_RELEASE_ASSETS} %{CODEFLARE_RELEASE_ASSETS=https://github.com/opendatahub-io/distributed-workloads/releases/download/v2.13.1}
${NOTEBOOK_IMAGE} quay.io/modh/odh-generic-data-science-notebook@sha256:d81e47fa2f5656042748cf2cd1d97033f58d6dd707667ff0e25aa969959e56a7

Check warning

Code scanning / Robocop

Line is too long ({{ line_length }}/{{ allowed_length }}) Warning test

Line is too long (154/120)
${NOTEBOOK_USER_NAME} ${TEST_USER_3.USERNAME}
${NOTEBOOK_USER_PASSWORD} ${TEST_USER_3.PASSWORD}
${CODEFLARE_TEST_RAY_IMAGE} quay.io/rhoai/ray@sha256:859f5c41d41bad1935bce455ad3732dff9d4d4c342b7155a7cd23809e85698ab

Check warning

Code scanning / Robocop

Line is too long ({{ line_length }}/{{ allowed_length }}) Warning test

Line is too long (125/120)
${PIP_INDEX_URL} ${PIP_INDEX_URL}
${PIP_TRUSTED_HOST} ${PIP_TRUSTED_HOST}
${AWS_DEFAULT_ENDPOINT} ${S3.BUCKET_5.ENDPOINT}
${AWS_STORAGE_BUCKET} ${S3.BUCKET_5.NAME}
${AWS_ACCESS_KEY_ID} ${S3.AWS_ACCESS_KEY_ID}
${AWS_SECRET_ACCESS_KEY} ${S3.AWS_SECRET_ACCESS_KEY}
${AWS_STORAGE_BUCKET_MNIST_DIR} mnist-datasets


*** Test Cases ***
Expand Down Expand Up @@ -100,10 +108,18 @@
... env:CODEFLARE_TEST_TIMEOUT_MEDIUM=10m
... env:CODEFLARE_TEST_TIMEOUT_LONG=20m
... env:CODEFLARE_TEST_OUTPUT_DIR=%{WORKSPACE}/codeflare-odh-logs
... env:CODEFLARE_TEST_RAY_IMAGE=${CODEFLARE_TEST_RAY_IMAGE}
... env:ODH_NAMESPACE=${APPLICATIONS_NAMESPACE}
... env:NOTEBOOK_IMAGE=${NOTEBOOK_IMAGE}
... env:NOTEBOOK_USER_NAME=${NOTEBOOK_USER_NAME}
... env:NOTEBOOK_USER_TOKEN=${NOTEBOOK_USER_TOKEN}
... env:NOTEBOOK_IMAGE=${NOTEBOOK_IMAGE}
... env:AWS_DEFAULT_ENDPOINT=${AWS_DEFAULT_ENDPOINT}
... env:AWS_ACCESS_KEY_ID=${AWS_ACCESS_KEY_ID}
... env:AWS_SECRET_ACCESS_KEY=${AWS_SECRET_ACCESS_KEY}
... env:AWS_STORAGE_BUCKET=${AWS_STORAGE_BUCKET}
... env:AWS_STORAGE_BUCKET_MNIST_DIR=${AWS_STORAGE_BUCKET_MNIST_DIR}
... env:PIP_INDEX_URL=${PIP_INDEX_URL}
... env:PIP_TRUSTED_HOST=${PIP_TRUSTED_HOST}
Log To Console ${result.stdout}
IF ${result.rc} != 0
FAIL ${TEST_NAME} failed
Expand Down
1 change: 1 addition & 0 deletions ods_ci/tests/Tests/0600__distributed_workloads/test-run-kueue-e2e-tests.robot
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ Run Kueue E2E test
[Tags] Tier1
... Kueue
... DistributedWorkloads
... ExcludeOnDisconnected
Run Kueue E2E Test e2e_test.go

Run Sanity test
Expand Down
Loading