Code

RFC: Command abstraction for effects#291

Code

Merged

charypar merged 39 commits intomasterredbadger/crux:masterfrom viktor/commandredbadger/crux:viktor/commandCopy head branch name to clipboardJan 21, 2025

+3,368-3

Commits

Commits on Jan 21, 2025

• Start work on a Command abstraction

  

  charypar

  authored and

  StuartHarris

  committed
  4cf9035

  Copy full SHA for 4cf9035

• Implement shell request mechanics

  

  charypar

  authored and

  StuartHarris

  committed
  9d0434e

  Copy full SHA for 9d0434e

• Tidy up ShellRequest

  

  charypar

  authored and

  StuartHarris

  committed
  ec5dc2c

  Copy full SHA for ec5dc2c

• Implement shell streams

  

  charypar

  authored and

  StuartHarris

  committed
  2adf21b

  Copy full SHA for 2adf21b

• Implement event command

  

  charypar

  authored and

  StuartHarris

  committed
  069c65c

  Copy full SHA for 069c65c

• Add async API tests, fix ShellRequest

  

  charypar

  authored and

  StuartHarris

  committed
  11a889a

  Copy full SHA for 11a889a

• Implement spawning from inside tasks

  

  charypar

  authored and

  StuartHarris

  committed
  62a99fc

  Copy full SHA for 62a99fc

• Command can act as an an async stream + then combinator

  

  charypar

  authored and

  StuartHarris

  committed
  f12dc2e

  Copy full SHA for f12dc2e

• Switch to AtomicWaker and implement .and and ::all

  

  charypar

  authored and

  StuartHarris

  committed
  c11dd3f

  Copy full SHA for c11dd3f

• Add a more complex combinator test case, fix the Stream implementation

  

  charypar

  authored and

  StuartHarris

  committed
  2229fa8

  Copy full SHA for 2229fa8

• CommandBuilder to allow effect chaining without async

  

  charypar

  authored and

  StuartHarris

  committed
  7d010a1

  Copy full SHA for 7d010a1

• Command builders with explicit combinators

  

  charypar

  authored and

  StuartHarris

  committed
  651d453

  Copy full SHA for 651d453

• Make then combinator generic

  

  charypar

  authored and

  StuartHarris

  committed
  7936de3

  Copy full SHA for 7936de3

• Tests for universal capability APIs

  

  charypar

  authored and

  StuartHarris

  committed
  6a26aaf

  Copy full SHA for 6a26aaf

• Expand effect race test and fix resolving cancelled effects

  

  charypar

  authored and

  StuartHarris

  committed
  14afc38

  Copy full SHA for 14afc38

• Command mapping for app composition

  

  charypar

  authored and

  StuartHarris

  committed
  6c7732d

  Copy full SHA for 6c7732d

• Blanket implementation for hosting command streams

  

  charypar

  authored and

  StuartHarris

  committed
  0bb7378

  Copy full SHA for 0bb7378

• Implement hosting as a Sink to avoid async in trait

  

  charypar

  authored and

  StuartHarris

  committed
  d9b1c21

  Copy full SHA for d9b1c21

• Return iterators from events() and effects() to give the consumer more flexibility

  

  charypar

  authored and

  StuartHarris

  committed
  5f70664

  Copy full SHA for 5f70664

• Spawn returns a join handle

  

  charypar

  authored and

  StuartHarris

  committed
  32e9d52

  Copy full SHA for 32e9d52

• Tasks can be aborted

  

  charypar

  authored and

  StuartHarris

  committed
  9eaa914

  Copy full SHA for 9eaa914

• Immediate abort test

  

  charypar

  authored and

  StuartHarris

  committed
  710147b

  Copy full SHA for 710147b

• Commands can be aborted using their abort handle

  

  charypar

  authored and

  StuartHarris

  committed
  0248001

  Copy full SHA for 0248001

• Reorganise modules and add doccomments

  

  charypar

  authored and

  StuartHarris

  committed
  0ecb8fd

  Copy full SHA for 0ecb8fd

• Allow all combinations of chaining request builders

  

  charypar

  authored and

  StuartHarris

  committed
  8fc3509

  Copy full SHA for 8fc3509

• Tiny test tweak

  

  charypar

  authored and

  StuartHarris

  committed
  b38539f

  Copy full SHA for b38539f

• Draft the RFC text

  

  charypar

  authored and

  StuartHarris

  committed
  c15d41d

  Copy full SHA for c15d41d

• Add an integration test as the demonstration of command use

  

  charypar

  authored and

  StuartHarris

  committed
  f8cc6c1

  Copy full SHA for f8cc6c1

• A bit more contrived test to demonstrate chaining

  

  charypar

  authored and

  StuartHarris

  committed
  1cd4352

  Copy full SHA for 1cd4352

• Typos, clippy, et al

  StuartHarris

  committed
  a630947

  Copy full SHA for a630947

• Remove CommandBuilder trait in favour of explicit chaining APIs

  

  charypar

  authored and

  StuartHarris

  committed
  4fa6b41

  Copy full SHA for 4fa6b41

• Extract shell request state transition for readability

  

  charypar

  authored and

  StuartHarris

  committed
  d64741c

  Copy full SHA for d64741c

• Replace (channel, waker) pair with a one shot channel

  

  charypar

  authored and

  StuartHarris

  committed
  f3ee63f

  Copy full SHA for f3ee63f

• Cancel tasks which cannot be woken up

  

  charypar

  authored and

  StuartHarris

  committed
  44f1b7d

  Copy full SHA for 44f1b7d

• Fix join handles

  

  charypar

  authored and

  StuartHarris

  committed
  31b8333

  Copy full SHA for 31b8333

• Provide CommandContext to spawn

  

  charypar

  authored and

  StuartHarris

  committed
  6c6318d

  Copy full SHA for 6c6318d

• Build shell request on top of shell stream

  

  charypar

  authored and

  StuartHarris

  committed
  0ab0255

  Copy full SHA for 0ab0255

• Stronger guarantees on atomics

  

  charypar

  authored and

  StuartHarris

  committed
  d5977ac

  Copy full SHA for d5977ac

• then_request and then_stream docs for RequestBuilder and StreamBuilder

  StuartHarris

  committed
  212d7f5

  Copy full SHA for 212d7f5