remove references to jvm-build-service #5132
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: tnevrlka The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold |
tnevrlka
force-pushed
the
remove-jvm-build-service
branch
from
7e261f7 to
6c6aed6
Compare
| @@ -13,16 +13,19 @@ resources: | |||
| - tiertemplate-appstudio-clusterresources-593233715-593233715.yaml | |||
| - tiertemplate-appstudio-clusterresources-809836689-809836689.yaml | |||
| - tiertemplate-appstudio-contributor-1817914940-1817914940.yaml | |||
| - tiertemplate-appstudio-contributor-3265408548-3265408548.yaml | |||
There was a problem hiding this comment.
Sorry, it looks really messy, but I'm not aware of anything I can do about it.
The source of truth and the only thing I'm changing is in components/sandbox/tiers/src/appstudio.
We need such changes, because there are references to jvm-build-service and I'm removing them, see an example here
After changes are made in the directory, a command is ran as described in the README which autogenerates majority of the changes in 6c6aed6.
This seems to me to indeed be the intended workflow, see #5137 as an example
There was a problem hiding this comment.
This is normal. Changing one access in a role will case a generation of a new role file, thus explaining all those new lines. This is how kubesaw works to deploy the new tier.
tnevrlka
force-pushed
the
remove-jvm-build-service
branch
from
6c6aed6 to
de8f0d2
Compare
tnevrlka
force-pushed
the
remove-jvm-build-service
branch
from
de8f0d2 to
6fc49e7
Compare
It scares me a little bit, but it kinda makes sense to me when you consider this PR which only changes the maintainer file and has 1225 newly added lines. I've changed four files which could result in 4 times as many lines. It seems like it might be a good idea to get someone from infra to take a look at this though |
- jvm-build-service is currently not being used by anyone - It is going to undergo major breaking changes and is going to be removed for now until the changes are done
- There are mentions of jvm-build-service in components/sandbox/tiers - Manually remove the references from `components/sandbox/tiers/src` - Run `ksctl generate nstemplatetiers --source ./src --out-dir ./production` as mentioned in README (same for staging) which automatically generates many new files
tnevrlka
force-pushed
the
remove-jvm-build-service
branch
from
6fc49e7 to
430f589
Compare
|
@tnevrlka: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Split into two commits:
components/sandbox/tiersThe second commit contains files created by
ksctlas mentioned in https://github.com/redhat-appstudio/infra-deployments/blob/main/components/sandbox/tiers/README.adoc leading to thousands of newly added lines