Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mintmaker: add staging to production promotion pipeline #5171

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

qixiang
Copy link
Collaborator

@qixiang qixiang commented Dec 17, 2024

Add PipelineRun to automatically promote changes from staging to production.

When mintmaker staging kustomization.yaml is updated, the pipeline:

  • Updates production kustomization.yaml with corresponding SHAs from staging
  • Creates a pull request if any SHAs have changed

This automates the staging to production promotion workflow for mintmaker.

Add PipelineRun to automatically promote changes from staging to
production.

When mintmaker staging kustomization.yaml is updated, the pipeline:
- Updates production kustomization.yaml with corresponding SHAs from
  staging
- Creates a pull request if any SHAs have changed

This automates the staging to production promotion workflow for
mintmaker.
@qixiang qixiang force-pushed the mintmaker-stage-to-prod-promotion-plr branch from 420db7d to f0652d0 Compare December 17, 2024 13:32
@qixiang
Copy link
Collaborator Author

qixiang commented Dec 17, 2024

I don't know how to test this new PipelineRun, but the embedded shell script has been tested locally.

@qixiang
Copy link
Collaborator Author

qixiang commented Dec 17, 2024

@hugares I'm not sure who can review and approve this. Could you help or let me know who I should request review from?

@qixiang
Copy link
Collaborator Author

qixiang commented Jan 9, 2025

@gnaponie @staticf0x before someone has the permission to approve this, could you take a look if this looks good to you?

@gnaponie
Copy link
Contributor

gnaponie commented Jan 9, 2025

/approve
/lgtm

@qixiang
Copy link
Collaborator Author

qixiang commented Jan 9, 2025

Once this PR has been reviewed and has the lgtm label, please assign tisutisu for approval. For more information see the Code Review Process.

@tisutisu could you help to review this?

@qixiang qixiang requested a review from tisutisu January 9, 2025 08:51
Copy link
Contributor

@staticf0x staticf0x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I also don't know how to test it

Copy link

openshift-ci bot commented Jan 9, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: gnaponie, qixiang, staticf0x
Once this PR has been reviewed and has the lgtm label, please assign tisutisu for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants