Backup additional resources #5224
Conversation
Add additional resources to the backup as follows: 1. rolebindings - users a allowed to create role binding for their service account. In addition, in clusters that doesn't use kubesaw, rolebindings are used for granting permissions to users. 2. imagerepositories - the ImageRepository resources is created by the UI when onboarding a new component, thus it should be backed up as well. 3. repositories - the Tekton repository resource is created by the build service if the component doesn't have the "build.appstudio.openshift.io/status" annotation. Since the components in the back have this annotation, the build service won't create the repository resources after restoring the components, thus the repository resource should be backed up as well. 4. release resources - those are core Konflux resources thus they should be backed up as well. Signed-off-by: Gal Ben Haim <[email protected]>
gbenhaim
requested review from
bamachrn,
manish-jangra and
eisraeli
and removed request for
skabashnyuk and
elsony
|
@gbenhaim: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gbenhaim, manish-jangra The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| - repositories.pipelinesascode.tekton.dev | ||
| - releases.appstudio.redhat.com | ||
| - releaseplans.appstudio.redhat.com | ||
| - releaseplanadmissions.appstudio.redhat.com |
There was a problem hiding this comment.
Maybe backing up specific resources was a wrong approach to start with. We will always be in catch up mode, i.e. adding resource to back up after trying to recover them and realizing that they are not in the backup. Should we back up all resources in the namespaces that are not excluded instead?
We will use more storage but at least we will be sure that a new added resources will not be missing from backup
Add additional resources to the backup as follows:
rolebindings - users a allowed to create role binding for their service account. In addition, in clusters that doesn't use kubesaw, rolebindings are used for granting permissions to users.
imagerepositories - the ImageRepository resources is created by the UI when onboarding a new component, thus it should be backed up as well.
repositories - the Tekton repository resource is created by the build service if the component doesn't have the "build.appstudio.openshift.io/status" annotation. Since the components in the back have this annotation, the build service won't create the repository resources after restoring the components, thus the repository resource should be backed up as well.
release resources - those are core Konflux resources thus they should be backed up as well.