Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(KFLUXVNGD-93): Grant appstudio-pipelines-runner permissions to manage namespaces #5232

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

hmariset
Copy link
Contributor

@hmariset hmariset commented Jan 6, 2025

Grant the appstudio-pipelines-runner serviceaccount permission to manage
namespaces.eaas.konflux-ci.dev resources.

Jira-Url: https://issues.redhat.com/browse/KFLUXVNGD-93

@hmariset hmariset requested a review from amisstea January 6, 2025 23:28
Copy link
Contributor

@amisstea amisstea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit message & PR title are misleading. What you're attempting to do is grant the appstudio-pipelines-runner serviceaccount permission to manage namespaces.eaas.konflux-ci.dev resources. Please correct them.

…manage namespaces

Grant the appstudio-pipelines-runner serviceaccount permission to manage
namespaces.eaas.konflux-ci.dev resources.

Jira-Url: https://issues.redhat.com/browse/KFLUXVNGD-93
Signed-off-by: Homaja Marisetty <[email protected]>
@hmariset hmariset changed the title chore(KFLUXVNGD-93): Add eaas group to the toolchain-member-operator chore(KFLUXVNGD-93): Grant appstudio-pipelines-runner permissions to manage namespaces Jan 7, 2025
Copy link
Contributor

@amisstea amisstea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jan 7, 2025
@hmariset hmariset requested a review from filariow January 7, 2025 16:05
Copy link
Member

@filariow filariow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

openshift-ci bot commented Jan 7, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: amisstea, filariow, hmariset

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Jan 7, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit e618808 into redhat-appstudio:main Jan 7, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants