Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add pod reader role to appstudio-pipeline SA #5343

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

tisutisu
Copy link
Member

In konflux-ci namespace, appstudio-pipeline SA needs pod reader role to archive e2e-tests logs.

@openshift-ci openshift-ci bot requested review from ksprinkl and lcarva January 22, 2025 07:42
@tisutisu tisutisu force-pushed the add-pod-reader branch 3 times, most recently from 6d04844 to 086e598 Compare January 22, 2025 08:26
components/konflux-ci/base/pod-reader-role.yaml Outdated Show resolved Hide resolved
@mmorhun
Copy link
Member

mmorhun commented Jan 23, 2025

/approve
/lgtm

Copy link

openshift-ci bot commented Jan 23, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mmorhun, tisutisu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 10c3fe9 into redhat-appstudio:main Jan 23, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants