fix: version 2022.3 breaks by marking PreloadingActivity for internal usage

[TomerFi]

Fixes #35, Fixes #76, Fixes #81, Fixes #91, Fixes #92

Tested locally with versions:

• 2021.1 (our minimum target)
• 2022.2
• 2022.3 (the latest version)

Edit 1:
Looks like this fix, though fixed the issue at hand, introduced a new one.
With this fix, diagnostic is only performed for modifying an already open file, and not for opening one.

Edit 2:
The cause for the error described in Edit 1 is lsp4intellij.
This bug was introduced in version 0.95.1, and can be demonstrated using the master-snapshot as well.
However, pinning the version to 0.95.0 resolves this issue.
Pinning the version is handled in #106.

[github-advanced-security]

You have successfully added a new SonarCloud configuration ``. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

[TomerFi]

/hold

[TomerFi]

/unhold

[jeffmaury]

Dependency changes should be in a separate PR

[TomerFi]

Dependency changes should be in a separate PR

@jeffmaury
#106

[TomerFi]

rebased from the master after previous prs merged.

[jeffmaury]

Seems to be several concerns are mixed in this PR

[TomerFi]

Seems to be several concerns are mixed in this PR

@jeffmaury
First of all, thank you for your review.
Secondly, if there are multiple concerns here, it's because they are entangled with each other.

Background
This project uses lsp4intellij@master-SNAPSHOT (see #106).
This projects latest release (0.5.0) was on January 16th.
The README for lsp4intellij on that date looked something like this, which matches this plugin configuration at the time of the release build.

Today, the configuration is different, not only is it now used as a application service instead of the deprecated application component, but the extensions configuration is completely different now. You can check this compare link and pay extra attention to the original README.md vs. the current plugin.xml.example.

Initial Issue
As explained in #91, IntelliJ 2022.3 broke the the way we download the executables.
To fix that, I switched the usage of the broken Preload Activity to a more stable approach using the Application Lifecycle Listener.

This seems to do the trick, now the executables were downloaded as expected, and I could verify stack analysis was working again.

But... I couldn't verify component analysis because, as mentioned in the background, we're using a SNAPSHOT lsp4intellij and its configuration was changed dramatically from the last build done for this plugin's 0.5.0 release.
So I adapted the configuration accordingly and pushed this PR.

Happy Side Effect
As I was verifying our fix works with the adapted configuration of lsp4intellij, I was also able to verify that this configuration adaptation seems to also resolves #35, #76, #81, and #92.

[jeffmaury]

I see another PR for updating the lsp4intellij dependency, so:

• are the changes related to lsp4intellij in this PR relevant in the other PR and in that case they should be in this PR
• if not they should be removed and this PR rebased after the other PR has been merged

[TomerFi]

@jeffmaury

I see another PR for updating the lsp4intellij dependency, so:

Yeah, you mean #106 which I opened based on one of your requests.

• are the changes related to lsp4intellij in this PR relevant in the other PR and in that case they should be in this PR

They were in this PR but you asked me to take it out:

• if not they should be removed and this PR rebased after the other PR has been merged

They are not related, #106 is meant to fix another issue caused by a bad practice used in this plugin's design.

i.e. using unstable snapshot versions made us oblivious to the fact that lsp4intellij version 0.95.1 broke diagnostics for opening files (works only for modifying files), hence #106 is pinning lsp4intellij to the last known working version 0.95.0 instead of the unstable snapshot version used today.

[TomerFi]

Rebased.

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[ruromero]

LGTM

[ruromero]

@jeffmaury do you have any further comments? If not we will merge it.
Thanks in advance.