Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle UTF-8 characters in command arguments #3075

Merged
merged 1 commit into from
Dec 30, 2024
Merged

Handle UTF-8 characters in command arguments #3075

merged 1 commit into from
Dec 30, 2024
+36 −21

Conversation

tishun
Copy link
Collaborator

@tishun tishun commented Dec 12, 2024

Closes #3071

Make sure that:

  • You have read the contribution guidelines.
  • You have created a feature request first to discuss your contribution intent. Please reference the feature request ticket number in the pull request.
  • You applied code formatting rules using the mvn formatter:format target. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.

@tishun tishun force-pushed the topic/tishun/issue-3071 branch from 8bdaf6e to 80959fa Compare December 13, 2024 09:38
ggivo
ggivo reviewed Dec 13, 2024
View reviewed changes
Copy link
Contributor

@ggivo ggivo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tishun tishun force-pushed the topic/tishun/issue-3071 branch from 80959fa to 95baf91 Compare December 30, 2024 14:58
@tishun tishun merged commit ce92e6a into redis:main Dec 30, 2024
4 checks passed
@tishun tishun deleted the topic/tishun/issue-3071 branch December 30, 2024 17:20
thachlp pushed a commit to thachlp/lettuce that referenced this pull request Dec 31, 2024
@tishun @thachlp
Handle UTF-8 characters in command arguments (redis#3075)
fbb3951
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggivo ggivo ggivo left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LettuceConnectionFactory is not establishing the connection when using a Japanese username and password
2 participants
@tishun @ggivo