Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extra spaces in words in docs #3120

Merged
merged 3 commits into from
Jan 8, 2025
Merged

Conversation

enjoy-binbin
Copy link
Contributor

@enjoy-binbin enjoy-binbin commented Jan 7, 2025

There are extra spaces between some words in these sentences.
Other than that, diff is all table formatting.

`reset LatenciesAfterEvent` should be `resetLatenciesAfterEvent`.
`ev entEmitIntervalUnit` should be `eventEmitIntervalUnit`.
Other than that, diff is all table formatting.
@enjoy-binbin enjoy-binbin changed the title Remove extra spaces in words Remove extra spaces in words in docs Jan 7, 2025
@ggivo ggivo added the type: documentation A documentation update label Jan 8, 2025
@ggivo
Copy link
Contributor

ggivo commented Jan 8, 2025

Hi @enjoy-binbin,
I found a few more typos with missing spaces in the same .md file. Do you think we can address them with the same PR?

Line 190: commandLatency CollectorOptions(…) should be commandLatencyCollectorOptions(…).
Line 191: DefaultCom mandLatencyCollectorOptions.disabled() should be DefaultCommandLatencyCollectorOptions.disabled().
Line 298: Client Options should be ClientOptions.
Line 467: 10 seconds Connecti on-Timeout, no keep-a live, no TCP noDelay should be 10 seconds Connection-Timeout, no keep-alive, no TCP noDelay.
Line 479: (non e), use JDK defaults should be (none), use JDK defaults.
Line 582: enableAda ptiveRefreshTrigger should be enableAdaptiveRefreshTrigger.
Line 600: adaptiveRef reshTriggersTimeout should be adaptiveRefreshTriggersTimeout.
Line 613: refreshTrigge rsReconnectAttempts should be refreshTriggersReconnectAttempts.
Line 625: dy namicRefreshSources should be dynamicRefreshSources.
Line 644: cl oseStaleConnections should be closeStaleConnections.
Line 689: validateCl usterNodeMembership should be validateClusterNodeMembership.

The following ones are already addressed in PR #3118 so I suggest leaving them aside to avoid the conflict

    Line 330: pingBefor eActivateConnection should be pingBeforeActivateConnection.
    Line 366: cancelCommand sOnReconnectFailure should be cancelCommandsOnReconnectFailure.
    Line 489: Do n ot timeout commands. should be Do not timeout commands.
    Line 552: en ablePeriodicRefresh should be enablePeriodicRefresh.

PS: tried to suggest a change but GitHub seems to not allow this for lines not modified in the PR.

@enjoy-binbin
Copy link
Contributor Author

thanks, and yes, i can address them in the same PR, i update the PR (it seems that there is no need to update the top comments, they are all very small).

PS: tried to suggest a change but GitHub seems to not allow this for lines not modified in the PR.

this is ture, GH not allow doing this, another way is to push commit directly to this branch, like doing gh pr checkout 3120

@ggivo ggivo merged commit a8613e8 into redis:main Jan 8, 2025
4 checks passed
@ggivo
Copy link
Contributor

ggivo commented Jan 8, 2025

@enjoy-binbin Merged.
Thanks for the hint and for spending time on this issue!

@enjoy-binbin enjoy-binbin deleted the cleanup_word branch January 9, 2025 02:49
@tishun
Copy link
Collaborator

tishun commented Jan 11, 2025

Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation A documentation update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants