-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Throw redis exceptions #305
Closed
JuliusMikkela
wants to merge
123
commits into
redis:main
from
JuliusMikkela:feature/throw-redis-exceptions
Closed
Throw redis exceptions #305
JuliusMikkela
wants to merge
123
commits into
redis:main
from
JuliusMikkela:feature/throw-redis-exceptions
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oval-readme-updates Ulid geoattribute removal readme updates
* moving some things around, adding stylecop, cleanup * Adding strict formatting analyzer. * more cleanup
* updating readme
* adding badges
* changing licence badge
* NRedisPlus->Redis.OM
* Copy edit. Co-authored-by: Stephen Lorello <[email protected]>
* namespace updates
* Updating Readme
* revving to v0.1.0 * updating JSON.ARRINDEX in script, reflecting removal of sortable TAGs for JSON * fixing line endings, updating sentinel
* Improving parsing for GeoLocs
redis#23) * fixing issue with index null checking, and equality check for numerics
* addressing DateTime serialization issue, making sure ids can be generated correctly
* Docs adjustments 1. Removed the Index attribute from the `Email` property, that is to show that not all properties require to be indexed. 2. Replaced the `Sortable` attribute from the `LastName` property with `Aggregatable`, that is to show that not all Index attribute requires such property. 3. Adjusted the creation of the Redis index to directly access `IRedisConnection` through the `RedisConnectionProvider`. That is to avoid confusion of not knowing how to access `IRedisConnection` The current documentation is missing the `connection` variable creation, such as - var connection = provider.Connection; As working directly on the `IRedisConnection` shouldn't be needed in such a wrapper I simply skipped that variable and used `Provider.Connection` directly. 4. Added an example of inserting a new document, that is to show that an insert doesn't need to be made on `IRedisConnection` via some of the Set commands, as an abstraction is available using `IRedisCollection` directly.
* adding contributing docs
…RedisIdFieldAttribute (redis#34) * Refactor RedisObjectHandler.SetId 1.Adjusted to easier to maintain type check. 2. Removed non working default check on object type. 3.Removed idProperty.SetValue(obj, id); to avoid exceptions when property is not of type string. * Adjusted order of if statements * some updates for id generation Co-authored-by: Ben <[email protected]> Co-authored-by: slorello89 <[email protected]>
I tried using the POC app and found that the the Insert Object was missing. So added the same Co-authored-by: satish venkatakrishnan <[email protected]>
* adding readme/release notes to package
* Mandating Index as constructor parameter for `RedisQuery`
add low level search example
* adding ability to index and query datetimes * fixing sortable bit of index creation
add overload for Insert method to support bulk insert
…edis#273) * forcing reload on scripting error, using correct sha in some tests * revving version * fixing accidental reversion
* Introduced configurable TimeZone for DateTimeJsonConverter - New static RedisSerializationSettings for centralized serialization config - UseUtcTime & UseLocalTime settings - Moved a lot of duplicated JsonSerializerSettings into RedisSerializationSettings
JuliusMikkela
force-pushed
the
feature/throw-redis-exceptions
branch
from
February 9, 2023 09:18
c426a34
to
154469f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made a few changes so that exceptions thrown by Redis OM are based on RedisException, which makes catching and handling redis-related issues far easier. Solves #300