Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw redis exceptions #305

Closed

Conversation

JuliusMikkela
Copy link
Contributor

Made a few changes so that exceptions thrown by Redis OM are based on RedisException, which makes catching and handling redis-related issues far easier. Solves #300

slorello89 and others added 30 commits October 14, 2021 13:22
…oval-readme-updates

Ulid geoattribute removal readme updates
* moving some things around, adding stylecop, cleanup

* Adding strict formatting analyzer.

* more cleanup
* updating readme
* adding badges
* changing licence badge
* NRedisPlus->Redis.OM
* Copy edit.
Co-authored-by: Stephen Lorello <[email protected]>
* namespace updates
Adding icon
* square icon
* Updating Readme
* revving to v0.1.0

* updating JSON.ARRINDEX in script, reflecting removal of sortable TAGs for JSON

* fixing line endings, updating sentinel
* Improving parsing for GeoLocs
redis#23)

* fixing issue with index null checking, and equality check for numerics
* addressing DateTime serialization issue, making sure ids can be generated correctly
* Docs adjustments

1. Removed the Index attribute from the `Email` property, that is to show that not all properties require to be indexed.

2. Replaced the `Sortable` attribute from the `LastName` property with `Aggregatable`, that is to show that not all Index attribute requires such property.

3. Adjusted the creation of the Redis index to directly access `IRedisConnection` through the `RedisConnectionProvider`.
That is to avoid confusion of not knowing how to access `IRedisConnection`
The current documentation is missing the `connection` variable creation, such as - 
var connection = provider.Connection;
As working directly on the `IRedisConnection` shouldn't be needed in such a wrapper I simply skipped that variable and used `Provider.Connection` directly.

4. Added an example of inserting a new document, that is to show that an insert doesn't need to be made on `IRedisConnection` via some of the Set commands, as an abstraction is available using `IRedisCollection` directly.
* adding contributing docs
…RedisIdFieldAttribute (redis#34)

* Refactor RedisObjectHandler.SetId

1.Adjusted to easier to maintain type check.
2. Removed non working default check on object type.

3.Removed idProperty.SetValue(obj, id); to avoid exceptions when property is not of type string.

* Adjusted order of if statements

* some updates for id generation

Co-authored-by: Ben <[email protected]>
Co-authored-by: slorello89 <[email protected]>
I tried using the POC app and found that the the Insert Object was missing. So added the same

Co-authored-by: satish venkatakrishnan <[email protected]>
* adding readme/release notes to package
* Mandating Index as constructor parameter for `RedisQuery`
Richard P. Field III and others added 25 commits October 11, 2022 11:54
add low level search example
* adding ability to index and query datetimes

* fixing sortable bit of index creation
add overload for Insert method to support bulk insert
…edis#273)

* forcing reload on scripting error, using correct sha in some tests

* revving version

* fixing accidental reversion
* Introduced configurable TimeZone for DateTimeJsonConverter

- New static RedisSerializationSettings for centralized serialization config
- UseUtcTime & UseLocalTime settings
- Moved a lot of duplicated JsonSerializerSettings into RedisSerializationSettings
@JuliusMikkela JuliusMikkela force-pushed the feature/throw-redis-exceptions branch from c426a34 to 154469f Compare February 9, 2023 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RedisConnection doesn't propogate redis connection exceptions when AbortOnConnectFail = true