Bugfix - Enumerating collection with documents expiring causes early return #422
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses bug found in #421 i.e. enumerating a collection from a search where the documents were expiring causes an early return resulting in less documents than expected.
@slorello89 Side note - I noticed that the non-generic SearchResponse would return an empty Document i.e. an empty dictionary documentHash, akin to returning null. But the generic
SearchResponse<T>
just skips the document instead. In the same vein, AggregationResult and AggregationResult<T> also seem to have a general pattern of returningnull
to their callers (whether internal or external to this package). This seemed like an unexpected functional difference between these classes that all handle aRedisReply
s so I wanted to call it to your attention for potential future review since these would be out of scope of a patch.