Skip to content

Commit

Permalink
Add support for refinerycms-core 4.0
Browse files Browse the repository at this point in the history
  • Loading branch information
bricesanchez committed Oct 3, 2017
1 parent 4beaf69 commit 8e19450
Show file tree
Hide file tree
Showing 8 changed files with 19 additions and 17 deletions.
7 changes: 3 additions & 4 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,7 @@ notifications:
webhooks:
- https://webhooks.gitter.im/e/b5d48907cdc89864b874
rvm:
- 2.3.1
- 2.2
- 2.1
- 2.0.0
- 2.4.2
- 2.3.5
- 2.2.8
sudo: false
2 changes: 1 addition & 1 deletion Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ group :assets do
end

group :development do
gem 'quiet_assets'
gem 'listen'
end

group :test do
Expand Down
12 changes: 9 additions & 3 deletions bin/rails
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
#!/usr/bin/env ruby
# This command will automatically be run when you run "rails" with Rails 3 gems installed from the root of your application.
# This command will automatically be run when you run "rails" with Rails gems
# installed from the root of your application.

ENGINE_PATH = File.expand_path('../..', __FILE__)
load File.expand_path('../../spec/dummy/bin/rails', __FILE__)
begin
load File.join(File.expand_path('../../', __FILE__), 'spec/dummy/bin/rails')
rescue LoadError => load_error
warn "No dummy Rails application found! \n" \
"To create one in spec/dummy, please run: \n\n" \
" rake refinery:testing:dummy_app"
end
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
class CreateRefinerycmsSettingsSchema < ActiveRecord::Migration
class CreateRefinerycmsSettingsSchema < ActiveRecord::Migration[4.2]
def change
create_table :refinery_settings do |t|
t.string :name
Expand Down
2 changes: 1 addition & 1 deletion db/migrate/20130414130143_add_slug_to_refinery_settings.rb
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
class AddSlugToRefinerySettings < ActiveRecord::Migration
class AddSlugToRefinerySettings < ActiveRecord::Migration[4.2]
def change
add_column :refinery_settings, :slug, :string, :unique => true
end
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
class AddTitleToRefinerySettings < ActiveRecord::Migration
class AddTitleToRefinerySettings < ActiveRecord::Migration[4.2]
def change
add_column :refinery_settings, :title, :string
end
Expand Down
6 changes: 3 additions & 3 deletions refinerycms-settings.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
Gem::Specification.new do |s|
s.platform = Gem::Platform::RUBY
s.name = %q{refinerycms-settings}
s.version = %q{3.0.1}
s.version = %q{4.0.0}
s.summary = %q{Settings engine for Refinery CMS}
s.description = %q{Adds programmer creatable, user editable settings.}
s.email = %q{[email protected]}
Expand All @@ -15,6 +15,6 @@ Gem::Specification.new do |s|
s.files = `git ls-files`.split("\n")
s.test_files = `git ls-files -- spec/*`.split("\n")

s.add_dependency 'refinerycms-core', ['~> 3.0', '>= 3.0.0']
s.add_dependency 'friendly_id', ['~> 5.0', '>= 5.0.1']
s.add_dependency 'refinerycms-core', ['~> 4.0', '>= 4.0.0']
s.add_dependency 'friendly_id', ['>= 5.1.0', '< 5.3']
end
3 changes: 0 additions & 3 deletions spec/features/refinery/admin/settings_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,6 @@ module Admin
click_button "submit_button"
end
expect(page).not_to have_css("#dialog_iframe")
expect(page).to have_content("'Test Setting' was successfully added.")
expect(page).to have_content("Test Setting - true")
end

Expand All @@ -64,7 +63,6 @@ module Admin
click_button "submit_button"
end

expect(page).to have_content("'Test/Setting' was successfully added.")
expect(page).to have_content("Test/Setting - true")

visit refinery.edit_admin_setting_path(Refinery::Setting.last)
Expand All @@ -90,7 +88,6 @@ module Admin
click_button "Save"
end

expect(page).to have_content("'Edit and Update Title' was successfully updated.")
expect(page).to have_content("Edit and Update Title - 2")
end
end
Expand Down

0 comments on commit 8e19450

Please sign in to comment.