Fix setting verify for requests #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to bug psf/requests#3829, setting 'verify' on session doesn't work if REQUESTS_CA_BUNDLE is set on environment. The bundle defined via REQUESTS_CA_BUNDLE will take precedence and the custom bundle provided via 'verify' is ignored. Let's now set 'verify' for each request. This can be revetrted when the bug is fixed, likely in python-requests-v3.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #219 +/- ##
=======================================
Coverage 96.89% 96.89%
=======================================
Files 8 8
Lines 997 998 +1
=======================================
+ Hits 966 967 +1
Misses 31 31
☔ View full report in Codecov by Sentry. |
rohanpm
approved these changes
Oct 29, 2023
| # set verify for each request | ||
| # verify set on session doesn't work due to https://github.com/psf/requests/issues/3829 | ||
| # if REQUESTS_CA_BUNDLE is set on env, it takes precedence | ||
| kwargs["verify"] = self._session.verify |
There was a problem hiding this comment.
I'm not certain which is better, but there is also a trust_env var you can set on the session to False.
Lately my approach has been: if the Session will have either verify or proxies used, then always set explicitly (verify, proxies, trust_env=False).
There was a problem hiding this comment.
your approach sounds also good, I guess I'll keep it simple for the time being.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to bug psf/requests#3829, setting 'verify' on session doesn't work if REQUESTS_CA_BUNDLE is set on environment. The bundle defined via REQUESTS_CA_BUNDLE will take precedence and the custom bundle provided via 'verify' is ignored.
Let's now set 'verify' for each request.
This can be revetrted when the bug is fixed, likely in python-requests-v3.