Make publishing of repos optional [RHELDST-21951] #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #221 +/- ##
==========================================
+ Coverage 96.89% 96.96% +0.07%
==========================================
Files 8 8
Lines 998 990 -8
==========================================
- Hits 967 960 -7
+ Misses 31 30 -1 ☔ View full report in Codecov by Sentry. |
drepelov
force-pushed
the
remove_publish
branch
from
6ba7e91 to
bdb5ba2
Compare
rbikar
requested changes
Jan 4, 2024
drepelov
force-pushed
the
remove_publish
branch
from
bdb5ba2 to
dda4c7c
Compare
drepelov
changed the title
After the rhel-ubi repos sync, this tool also took care of publishing the affected ubi repos to the CDN. However, this did not work for Exodus. It was decided that all publishes should be done via Pub, which is already configured and works for Exodus. This commit prepares this tool for removal of publishing by making it possible to switch the publishing on/off as needed. It also removes the intended deduplication of srpms in `_get_pulp_actions_src_pkgs()` which was a bit confusing and also unnecessary, since deduplication is done during manifest creation. Finally, it removes some forgotten unused variables and renames some variables so it's more understandable.
drepelov
force-pushed
the
remove_publish
branch
from
dda4c7c to
c0dbf3a
Compare
rbikar
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the rhel-ubi repos sync, this tool also took care of publishing the affected ubi repos to the CDN. However, this did not work for Exodus. It was decided that all publishes should be done via Pub, which is already configured and works for Exodus.
This commit prepares this tool for removal of publishing by making it possible to switch the publishing on/off as needed.
It also removes the intended deduplication of srpms in
_get_pulp_actions_src_pkgs()which was a bit confusing and also unnecessary, since deduplication is done during manifest creation. Finally, it removes some forgotten unused variables and renames some variables so it's more understandable.