-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the failture of ubipop for rhel7 #240
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -427,14 +427,18 @@ def test_run_ubi_pop_for_rhel7(pulp_client): | |
), "Can't find the modulemd_default :{}".format(modulemd_defaults) | ||
|
||
# verify the modulemd exist and modulemd default in the cdn server | ||
modulemds = query_repo_modules(None, "ubi", rpm_repo_url, full_data=True) | ||
modulemds = query_repo_modules(None, "ubi", rpm_repo_url) | ||
while "" in modulemds: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. can you move this to There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. the same as below comments, i will close the merge request. |
||
modulemds.remove("") | ||
assert len(modulemds) == 3, "Unexpected repo modulemds found." | ||
# assert the module prefile | ||
modulemds = query_repo_modules(None, "ubi", rpm_repo_url, full_data=True) | ||
mod_name, mod_profile = separate_modules(modulemds)[0] | ||
assert mod_name == "httpd", "Expected modulemd: httpd, found modulemd: {}".format( | ||
mod_name | ||
) | ||
assert ( | ||
"common [d]" in mod_profile | ||
"common" in mod_profile | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Did really the output changed for default modules? Or do we have rather problem in testing data or ubi-population-tool? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. hi Robert, the cause is the same as previous one query_repo_modules. After some investigation, the method works well in fedora38, in fedora 40, it will return in wrong format |
||
), "Modulemd httpd should have common profile as default." | ||
|
||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you do another unnecessary call for the second time a few lines later, can you please refactor this so it does only one call and then filters received data in
query_repo_modules
?