Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Unhandled promise rejection. Deferred response and redirects #12569

Closed

Conversation

thomaswelton
Copy link

Added a failing test for remix-run/remix#10313

Bug Description

Remix server will crash due to an unhandled promise rejection if a loader returns a rejected promise and another part of the application has already issued a redirect response.

Test description

Fictional application that will list users of different organisations. The route /organizations/meta/users defined as

route('organizations/:orgId', 'routes/organizations.tsx', [
  route("users", "routes/organization-users.tsx"),
])

will display the organisation name in the parent routes/organizations.tsx and then show a list of users in an outlet from routes/organization-users.tsx.

If the user promise fails then this error is handled by the Await component and an error message is shown. This can be shown by visiting this organisation /organizations/justpark/users

The error will occur when visiting an organisation where the parent issues a redirect response. Visiting this page /organizations/facebook/users will successfully issue a redirect to the meta organisation, but then the server will crash due to the rejected promise from the users loader.

…r if a loader has issued a redirect response
Copy link

changeset-bot bot commented Dec 17, 2024

⚠️ No Changeset found

Latest commit: f3ce10f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Dec 17, 2024

Hi @thomaswelton,

Welcome, and thank you for contributing to React Router!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected].

Thanks!

- The Remix team

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Dec 17, 2024

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

thomasgauvin and others added 24 commits December 18, 2024 14:43
…n#12573)

* thomasgauvin: add documentation on how to contribute to the developer docs

* Update contributors.yml

* Simplify docs contributing instructions

---------

Co-authored-by: Brooks Lybrand <[email protected]>
…emix-run#12592)

* Update spa.md to include more details about generating the index.html

* Update docs/how-to/spa.md

---------

Co-authored-by: Brooks Lybrand <[email protected]>
…`.gitignore` (remix-run#12591)

* ignore .react-router

* decorate with note

* Update contributors.yml

---------

Co-authored-by: harshslated <[email protected]>
* docs: sessions and cookies

* Fix variable shadowing in example
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* docs (special-files): fix typo

* Update contributors.yml
pwdcd and others added 11 commits January 7, 2025 13:29
…emix-run#12618)

* docs: Added guide on combining `configure routes` and `file routes`

* Update docs/start/framework/routing.md

---------

Co-authored-by: Brooks Lybrand <[email protected]>
…un#12625)

* docs: add explanation of `ignoredRouteFiles` option to guide

* Update docs/how-to/file-route-conventions.md

---------

Co-authored-by: Brooks Lybrand <[email protected]>
These should appear both in VS Code and other IDEs, as well as in the reference docs website.
* Add HydrateFallback to the data-loading doc

* introduce HydrateFallback earlier and simplify the final example

* Add client data how-to

* Update "See also" section
@brophdawg11
Copy link
Contributor

Closing since this was provided in a more succinct example in #12764

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.