Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rename assets with CAIP : separator to windows-friendly - #418

Merged
merged 4 commits into from
Jan 18, 2024

Conversation

bkrem
Copy link
Member

@bkrem bkrem commented Jan 18, 2024

Context

  • @glitch-txs pointed out that we're encountering failed clones due to the CAIP : separator being a reserved character in Windows
  • Find and replace all assets and update references in code
  • Also:
    • losslessly compress images on main sample dapps/wallets

Copy link

vercel bot commented Jan 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
malicious-dapp-verify-simulation ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 18, 2024 9:06am
react-auth-dapp ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 18, 2024 9:06am
react-auth-wallet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 18, 2024 9:06am
react-dapp-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 18, 2024 9:06am
react-wallet-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 18, 2024 9:06am
vue-dapp-auth ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 18, 2024 9:06am
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
react-dapp-v2-cosmos-provider ⬜️ Ignored (Inspect) Visit Preview Jan 18, 2024 9:06am
react-dapp-v2-with-ethers ⬜️ Ignored (Inspect) Visit Preview Jan 18, 2024 9:06am
react-dapp-v2-with-web3js ⬜️ Ignored (Inspect) Visit Preview Jan 18, 2024 9:06am

@bkrem bkrem merged commit 3e866b3 into main Jan 18, 2024
12 checks passed
@bkrem bkrem deleted the chore/asset-compression-and-naming-convs branch January 18, 2024 09:11
@fukemy
Copy link

fukemy commented Aug 24, 2024

hello, can u guide me how did you get this svg icon with this lineargradient color. I tried to make some other svg with this color but not working

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants