First version of initial-analysis and inspect-* tools
#9
Conversation
…nik/pro-939-investigate-data-flow-potential-for-10608
… and `initial-analysis`; misc fixes
Domiii
changed the title
initial-analysisinitial-analysis and inspect-* tools
…e will now always have a single point of entry
…nik/pro-939-investigate-data-flow-potential-for-10608
| // We need a recordingId either from the legacy prompt or from the new mode. | ||
| const { recordingId } = scanReplayUrl(options.prompt); | ||
|
|
||
| if (shouldUseLegacyMode(recordingId)) { |
There was a problem hiding this comment.
NOTE: Only use the new workflow on selected recordings for now.
We generally want to remove this check once we can confirm that it works in all previous samples.
There was a problem hiding this comment.
NOTE: This is a json-in-json-out CLI wrapper to avoid bash encoding for tool calls via CLI.
| ); | ||
|
|
||
| // 1. Hackfix-override `argv`. | ||
| process.argv = [process.argv[0], process.argv[1], input.command, ...flattenedArgStrings]; |
There was a problem hiding this comment.
NOTE: Convert json to argv (because commander has no json mode).
| @@ -103,8 +103,9 @@ export async function annotateExecutionPoints( | |||
| const filePath = getFilePath(spec.repository, location.url); | |||
| const lines = fs.readFileSync(filePath, "utf8").split("\n"); | |||
| let found = false; | |||
| const targetLine = location.source.trim(); | |||
There was a problem hiding this comment.
NOTE: For some reason, the source line is not trimmed anymore. I only fixed this because it caused issues when re-testing 10609. 🤷♀️
|
|
||
| export const ExecutionPointSpecSchema = AnalysisDefaultSpecSchema; | ||
| export const ExecutionPointSpecSchema = AnalysisDefaultSpecSchema.extend({ |
There was a problem hiding this comment.
NOTE: Not sure why these props were removed
| */ | ||
| function ignoreMultiMediaImports() { | ||
| const fileUrl = pathToFileURL(__filename).toString(); |
There was a problem hiding this comment.
NOTE: We need this, so we can deal with multimedia imports (import myImage from "myImage.svg";) from our devtools dependency.
| @@ -41,6 +41,9 @@ export default class LocalGitRepo { | |||
|
|
|||
| async init(forceDelete: boolean): Promise<void> { | |||
| if (forceDelete) { | |||
| if (!this.url) { | |||
There was a problem hiding this comment.
NOTE: forceDelete is a legacy option, only needed when we annotate (and want to *re-*annotate) code.
There was a problem hiding this comment.
NOTE: This test passes 🎉
| @@ -0,0 +1,278 @@ | |||
| import { ArrayPreview, DefaultPreview, ObjectPreview, ValuePreview } from "./values"; | |||
There was a problem hiding this comment.
NOTE: This was the old script I used during my experiments. It has some advantages over our default preview rendering, but not worth the effort until we have better benchmarks.
There was a problem hiding this comment.
@Domiii we need to have a discussion about system architecture here. There is a ton of functionality here that is similar to / duplicative of stuff we have in the backend's analysis logic, and neither of these can use each other because they run in totally different environments.
| debug(JSON.stringify({ experimentalCommand: { command, spec: input.spec } }) + "\n"); | ||
|
|
||
| // const timeout = 15 * 1000; | ||
| const timeout = 30 * 1000; |
| return (process.env[envVar]?.length && process.env[envVar] !== "0") || false; | ||
| } | ||
|
|
||
| export function isReplayDevMode(): boolean { |
There was a problem hiding this comment.
Added REPLAY_DEV_MODE to make a few things a bit easier.
Domiii
deleted the
dominik/pro-939-investigate-data-flow-potential-for-10608
branch
npx jest)