Skip to content

Commit

Permalink
Nightly ci fixes (#7547)
Browse files Browse the repository at this point in the history
* [x] it's checked
  • Loading branch information
Wumpf authored Sep 30, 2024
1 parent d32aa44 commit 2bd5e25
Show file tree
Hide file tree
Showing 6 changed files with 21 additions and 10 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/reusable_bench.yml
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ jobs:
- name: Render benchmark result
if: github.ref == 'refs/heads/main'
run: |
python3 pip install --break-system-package google-cloud-storage==2.9.0
pip install --break-system-package google-cloud-storage==2.9.0
scripts/ci/render_bench.py crates \
--after $(date -d"30 days ago" +%Y-%m-%d) \
--output "gs://rerun-builds/graphs"
9 changes: 8 additions & 1 deletion .github/workflows/reusable_test_wheels.yml
Original file line number Diff line number Diff line change
Expand Up @@ -212,8 +212,15 @@ jobs:
# This used to cause issues on Windows during the setup of the pixi environment when running from inside `compare_snippet_output.py`.
run: pixi run -e wheel-test-min cpp-build-snippets

- name: Download test assets
if: ${{ !inputs.FAST }}
# Separated out of compare_snippet_output.py run so we control the pixi environment.
# This used to cause issues on Windows during the setup of the pixi environment when running from inside `compare_snippet_output.py`.
run: pixi run -e wheel-test-min python ./tests/assets/download_test_assets.py

- name: Run docs/snippets/compare_snippet_output.py
if: ${{ !inputs.FAST }}
# explicit target because otherwise cargo loses the target cache… even though this is the target anyhow…
# --no-py-build because rerun-sdk is already built and installed
run: pixi run -e wheel-test-min RUST_LOG=debug python docs/snippets/compare_snippet_output.py --target ${{ needs.set-config.outputs.TARGET }} --no-py-build --no-cpp-build
# --no-asset-download because we already downloaded the assets
run: pixi run -e wheel-test-min RUST_LOG=debug python docs/snippets/compare_snippet_output.py --target ${{ needs.set-config.outputs.TARGET }} --no-py-build --no-cpp-build --no-asset-download
2 changes: 1 addition & 1 deletion crates/store/re_dataframe/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
Part of the [`rerun`](https://github.com/rerun-io/rerun) family of crates.

[![Latest version](https://img.shields.io/crates/v/re_dataframe.svg)](https://crates.io/crates/re_dataframe)
[![Documentation](https://docs.rs/re_dataframe/badge.svg)](https://docs.rs/re_dataframe)
[![Documentation](https://docs.rs/re_dataframe/badge.svg)](https://docs.rs/re_dataframe?speculative-link)
![MIT](https://img.shields.io/badge/license-MIT-blue.svg)
![Apache](https://img.shields.io/badge/license-Apache-blue.svg)

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ namespace rerun.datatypes;

/// A 16bit unsigned integer.
struct UInt16 (
"attr.docs.unreleased",
"attr.arrow.transparent",
"attr.python.aliases": "int",
"attr.python.array_aliases": "int, npt.NDArray[np.uint16]",
Expand Down
6 changes: 3 additions & 3 deletions docs/content/reference/types/datatypes/uint16.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

11 changes: 7 additions & 4 deletions docs/snippets/compare_snippet_output.py
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,7 @@ def main() -> None:
parser = argparse.ArgumentParser(description="Run end-to-end cross-language roundtrip tests for all API examples")
parser.add_argument("--no-py", action="store_true", help="Skip Python tests")
parser.add_argument("--no-cpp", action="store_true", help="Skip C++ tests")
parser.add_argument("--no-asset-download", action="store_true", help="Skip downloading test assets")
# We don't allow skipping Rust - it is what we compate to at the moment
parser.add_argument("--no-py-build", action="store_true", help="Skip building rerun-sdk for Python")
parser.add_argument(
Expand Down Expand Up @@ -132,15 +133,17 @@ def main() -> None:
examples += [Example(subdir.replace("\\", "/"), name)]

examples = list(set(examples))

examples.sort()

print("----------------------------------------------------------")

print("Downloading test assets…")
run(["pixi", "run", "python", "./tests/assets/download_test_assets.py"])
print("")
if not args.no_asset_download:
print("Downloading test assets…")
run(["pixi", "run", "python3", "./tests/assets/download_test_assets.py"])
print("")

print("----------------------------------------------------------")
print("----------------------------------------------------------")

active_languages = ["rust"]
if not args.no_cpp:
Expand Down

0 comments on commit 2bd5e25

Please sign in to comment.