Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

re_format: add general format_int function #5754

Merged
merged 2 commits into from
Apr 4, 2024
Merged

re_format: add general format_int function #5754

merged 2 commits into from
Apr 4, 2024

Conversation

emilk
Copy link
Member

@emilk emilk commented Apr 3, 2024 •
edited by github-actions bot
Loading

What

Mostly as an experiment to see if this makes sense as a trait for num-traits (see rust-num/num-traits#315)

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

@emilk emilk added 🚜 refactor Change the code, not the functionality exclude from changelog PRs with this won't show up in CHANGELOG.md labels Apr 3, 2024
@emilk emilk mentioned this pull request Apr 3, 2024
Open
@emilk emilk merged commit 15eecd3 into main Apr 4, 2024
34 checks passed
@emilk emilk deleted the emilk/format-int branch April 4, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teh-cmc teh-cmc teh-cmc approved these changes

Assignees
No one assigned
Labels
exclude from changelog PRs with this won't show up in CHANGELOG.md 🚜 refactor Change the code, not the functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emilk @teh-cmc