Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix main CI by disabling rav1d/asm feature #7613

Merged
merged 2 commits into from
Oct 7, 2024
Merged

Fix main CI by disabling rav1d/asm feature #7613

merged 2 commits into from
Oct 7, 2024

Conversation

emilk
Copy link
Member

@emilk emilk commented Oct 7, 2024

What

This disables the asm feature of rav1d, which means:

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

@emilk emilk added exclude from changelog PRs with this won't show up in CHANGELOG.md 🚢 CI 🎞️ video labels Oct 7, 2024
@emilk
Copy link
Member Author

emilk commented Oct 7, 2024

@rerun-bot full-check

Copy link

github-actions bot commented Oct 7, 2024

✅ Full build: https://github.com/rerun-io/rerun/actions/runs/11214896778

@emilk emilk marked this pull request as draft October 7, 2024 11:55
@emilk emilk changed the title Try to fix main CI Fix main CI Oct 7, 2024
@emilk emilk marked this pull request as ready for review October 7, 2024 12:22
@emilk
Copy link
Member Author

emilk commented Oct 7, 2024

Testing nightly in: https://github.com/rerun-io/rerun/actions/runs/11215413314 (this shouldn't block this PR, but may produce problems that warrant a follow-up PR)

@rerun-io rerun-io deleted a comment from github-actions bot Oct 7, 2024
@emilk emilk merged commit 2945950 into main Oct 7, 2024
116 of 120 checks passed
@emilk emilk deleted the emilk/fix-main branch October 7, 2024 12:37
@emilk emilk mentioned this pull request Oct 7, 2024
3 tasks
@emilk emilk changed the title Fix main CI Fix main CI by disabling rav1d/asm feature Oct 7, 2024
@emilk
Copy link
Member Author

emilk commented Oct 7, 2024

Added a TODO to re-enable the asm feature on pip package builds in

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exclude from changelog PRs with this won't show up in CHANGELOG.md 🚢 CI 🎞️ video
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant