Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set egui expansion to 0.0 and selection stroke to 1px #8679

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

abey79
Copy link
Member

@abey79 abey79 commented Jan 14, 2025

Related

What

This PR entirely removes expansion, and sets the foreground stroke to 1px for active/selected widget. This makes text edit much more compact when active/selected (which unblocks #8586).

Chances are this breaks stuff or make stuff ugly, so let the (luckily now vaguely automated) hunt begin.

@abey79 abey79 added the ui concerns graphical user interface label Jan 14, 2025
Copy link

github-actions bot commented Jan 14, 2025

Web viewer built successfully. If applicable, you should also test it:

  • I have tested the web viewer
Result Commit Link Manifest
45ff4d2 https://rerun.io/viewer/pr/8679 +nightly +main

Note: This comment is updated whenever you push a commit.

@abey79 abey79 added the exclude from changelog PRs with this won't show up in CHANGELOG.md label Jan 14, 2025
@abey79
Copy link
Member Author

abey79 commented Jan 14, 2025

Can't do, because our button relay on the permanent expansion...

@abey79 abey79 closed this Jan 14, 2025
@abey79 abey79 reopened this Jan 14, 2025
@abey79
Copy link
Member Author

abey79 commented Jan 14, 2025

TODO: try to add some button_padding to compensate for the lost expand

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exclude from changelog PRs with this won't show up in CHANGELOG.md ui concerns graphical user interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant