Add new Transform3D partial updates snippet for all languages
#8690
Conversation
teh-cmc
added
🔨 testing
|
Web viewer built successfully. If applicable, you should also test it:
Note: This comment is updated whenever you push a commit. |
There was a problem hiding this comment.
Nice to have snippets for these, but I feel the code is maybe focusing a bit much on producing a nice/smooth animation, distracting from the actual meat of it (the partial updates). I'd like for our users to be able to open a snippet and right away find what they need, without too much extra fluff.
An easy fix would be to remove the step timeline (we already have log_tick, after all)
| rec.set_time_sequence("step", step); | ||
| rec.log( | ||
| "box", | ||
| &rerun::Transform3D::clear_fields().with_axis_length(15.0), |
There was a problem hiding this comment.
Argueblt we should just demonste one thing here (clear_fields) and skip the with_axis_length
There was a problem hiding this comment.
purposefully showing both: people need to know they don't need to (and shouldn't) log multiple rows in order to clear all data and reset one or more specific fields (and similarly, we need to make sure in the roundtrips that this indeed results in a single row for all languages).
There really is not much to be said that wouldn't be made clearer by just looking at the code. Specifically: * Look at the codegen changes. * Now look at the changes to one of the generated archetypes (probably `Transform3D`). * Now look especially at the changes to `transform3d_ext`. That one's important. * Now look at how the different "partial updates" snippets evolved. Overall I hate everything here, literally every single bit -- but that's the best I managed to get out of the status quo without ridiculous amounts of efforts. * DNM: requires #8690 * Closes #8582 --------- Co-authored-by: Antoine Beyeler <[email protected]>
Adds some much needed snippet for partial updates on
Transform3D.Much needed because A)
Transform3Dhas a long history of custom partial updatability hacks and B) users are very very likely to use that one.