-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filter entities in the UI (part 4): Add entity filtering in the blueprint tree #8706
Open
abey79
wants to merge
13
commits into
main
Choose a base branch
from
antoine/filt4-blueprint-tree-filter
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+797
−265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Web viewer built successfully. If applicable, you should also test it:
Note: This comment is updated whenever you push a commit. |
abey79
force-pushed
the
antoine/filt4-blueprint-tree-filter
branch
2 times, most recently
from
January 16, 2025 17:59
ba28745
to
af41caf
Compare
abey79
force-pushed
the
antoine/filt4-blueprint-tree-filter
branch
from
January 17, 2025 10:43
af41caf
to
8e97d10
Compare
…d/added tests for streams
Also: updated/added tree walking apis for `DataResultTree` and `ViewportBlueprint` Two problems: - matches `$origin` when it shouldn't - matches in-origin-tree entities for parts that are _above or at_ origin Both of these are not displayed, and thus should not be matched.
… when there are none
abey79
force-pushed
the
antoine/filt4-blueprint-tree-filter
branch
from
January 17, 2025 16:15
8e97d10
to
df8dd4e
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related
CustomContent
more useful #8645What
This PR implements entity filtering in the blueprint tree.
In important design principle applied here is that the filtering applies only on the visible part of items. This has two major consequence:
$origin
placeholder in the tree).Snapshot tests for this is coming in the next PR
blueprint-tree-filter.mp4