Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use glue_data when data is a list #21

Merged
merged 1 commit into from
Oct 1, 2024
Merged

Use glue_data when data is a list #21

merged 1 commit into from
Oct 1, 2024

Conversation

r-ash
Copy link
Member

@r-ash r-ash commented Oct 1, 2024 •
edited
Loading

This changed in tidyverse/glue#317 and has now been released in current CRAN version of glue causing fairly confusing downstream failures.

e.g. in Naomi

Error: Error: .onLoad failed in loadNamespace() for 'naomi', details:
  call: NULL
  error: is.environment(.envir) is not TRUE

@r-ash
Use glue_data when data is a list
0625461 
This changed in tidyverse/glue#317 and is not
in current CRAN version of glue causing fairly confusing downstream
failures.
@r-ash r-ash requested a review from M-Kusumgar October 1, 2024 14:18
M-Kusumgar
M-Kusumgar approved these changes Oct 1, 2024
View reviewed changes
Copy link

@M-Kusumgar M-Kusumgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@r-ash r-ash merged commit 0bfebd7 into master Oct 1, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@M-Kusumgar M-Kusumgar M-Kusumgar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@r-ash @M-Kusumgar