Feature/improve error msg #388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 23, 2019 16:37
…f complex But then they show a misleading error message...
javydreamercsw
suggested changes
Oct 23, 2019
diba1013
suggested changes
Oct 24, 2019
There was a problem hiding this comment.
We definitely need more tests, at least one for each specification. Therefore I would split this PR, have a better, more reliable and understandable error message and increase support for the specification (the same goes for XPath).
roesslerj
force-pushed
the
feature/improve-error-msg
branch
from
1a7bea3 to
2c820b9
Compare
|
Agreed. I reverted the last commit on this branch and have a separate branch. Thanks. |
diba1013
reviewed
Oct 24, 2019
diba1013
suggested changes
Oct 24, 2019
diba1013
suggested changes
Oct 24, 2019
added 2 commits
October 25, 2019 13:18
roesslerj
force-pushed
the
feature/improve-error-msg
branch
from
3dd399a to
9805c4e
Compare
diba1013
approved these changes
Oct 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve error message to resolve #303