This repository has been archived by the owner on Sep 2, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 495
[FIX] Trade: return loading spinner (RT-3453) #2532
Open
darkdarkdragon
wants to merge
542
commits into
ripple:release
Choose a base branch
from
darkdarkdragon:release-RT-3453
base: release
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[FIX] Gulp-related build errors & JSHint warnings
[TASK] RTJ: Banners (RT-3341)
Popup is dismissed when the user presses the [Esc] key while the popup is shown. This works for `rp-popup` directives only, not if the popup service is invoked directly.
Convert jade files to html and load them with ajax on the fly
Clean price ticker when trade pair changes, so user do not see data from previous pair while new data loads.
e2e tests for placing orders and trade pairs: Add/remove a custom trade pair using full Ripple addresses. Add/remove a custom trade pair using Ripple names. Place/remove order to XRP/USD.Bitstamp orderbook. Place/remove order to USD.Bitstamp/USD.Snapswap orderbook.
…ded wallet (RT-3349)
[FIX] Amount: Use scale instead of product_human
try to send BTC try to send USD try to send to federation address try to send invalid amount
Fixes a problem with the jade compilation
There's only one index file, everything that needs to be translated should go to layout file.
app.js doesn't contain translatable strings anymore.
use ng-html2js preprocessor to load templates in karma tests
[TEST] fix karma tests (RT-3361)
RT build process just got so much cooler
[FEATURE] Dismiss locale popup on Esc (RT-3280)
[FIX] History: show price for orders (RT-1385)
[FIX] Wrong bitstamp text on BTC page (RT-3420)
[FIX] USD and BTC gateway pages (RT-3422)
From a closed PR
[FIX] Trust: fix not to trust unfunded (RT-2957)
[TASK] Update unfunded banner text
[FIX] Trust: Add removing... button when removing trustline in basic view (RT-3373)
[FIX] Broken Bitstamp link (RT-3437)
when on unfunded account transaction is getting added to rpTxQueue, do not ask password - it is not needed
[FIX] Trade: Track by BookDirectory not index
Show only Available XRP. Do not allow to place an order if Available XRP <=0
Show 4 decimal places on XRP in balance widget
[FIX] Balance widget: 4 decimal places (RT-3390)
[FIX] Trade: show only Available XRP (RT-3389)
[FIX] do not ask pass on unfunded (RT-3433)
[TASK] Upload notice to Ripple Trade pausing ability to create new accounts (RT-3444)
When placing an order show loading spinner again.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When placing an order show loading spinner again.