Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MIPS extensions #69

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

djtodoro
Copy link

Adding two extensions for MIPS p8700 CPU:

  1. cmove (conditional move)
  2. lsp (load/store pair)

The official product page here:
https://mips.com/products/hardware/p8700/

Upstreaming of this in LLVM is in progress:
llvm/llvm-project#121394

Adding two extensions for MIPS p8700 CPU:
1. cmove (conditional move)
2. lsp (load/store pair)

The official product page here:
https://mips.com/products/hardware/p8700/

Upstreaming of this in LLVM is in progress.
@djtodoro
Copy link
Author

cc @asb :)

@lenary
Copy link

lenary commented Jan 2, 2025

This looks good to me, and uncontroversial :)

@cmuellner
Copy link
Collaborator

Thanks for the PR!

I see that the references to the two new extensions go to the product description of the MIPS P8700 Series.
If that product retires, will the extensions also retire? If not (which I assume), is there a reference for a description of the extensions independent of the product they implement?

Also, the docs on the product page don't mention the two extensions (Xmipscmov and Xmipslsp). The appendix of the P8700 programmer's guide only lists nine custom instructions (ccmov, ehb, ihb, ldp, lwp, mtlbwr, pref, sdp, swp). This repo is not the right place to define extensions. Instead, a document should be referenced where the extensions are defined (incl. CSRs, instructions, etc).

A specification of a custom extension should also include the vendor prefix (e.g. mips.ccmov).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants