Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change to http from https to work around Qualcomm IT SSL issues #390

Closed
wants to merge 2 commits into from
Closed

Change to http from https to work around Qualcomm IT SSL issues #390

wants to merge 2 commits into from
+2 −2

Conversation

james-ball-qualcomm
Copy link
Collaborator

Still need a fix for Python.

@james-ball-qualcomm james-ball-qualcomm linked an issue Jan 6, 2025 that may be closed by this pull request
Can't install python into devcontainer (SSL certificate failure) #388
Open
github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 6, 2025
View reviewed changes
Gemfile
@@ -2,7 +2,7 @@

ruby "3.2.3"

source "https://rubygems.org"
source "http://rubygems.org"

Check failure

Code scanning / CodeQL

Dependency download using unencrypted communication channel High

Dependency source URL uses the unencrypted protocol HTTP. Use HTTPS instead.

Copilot Autofix AI 8 days ago

The best way to fix the problem is to change the protocol of the source URL from HTTP to HTTPS. This ensures that the communication channel used to download the dependencies is encrypted, protecting against potential MITM attacks.

To implement this fix, we need to modify the Gemfile to use the HTTPS protocol for the source URL. Specifically, we will change the line source "http://rubygems.org" to source "https://rubygems.org".

Suggested changeset 1
Gemfile

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/Gemfile b/Gemfile
--- a/Gemfile
+++ b/Gemfile
@@ -4,3 +4,3 @@
 
-source "http://rubygems.org"
+source "https://rubygems.org"
 
EOF
@@ -4,3 +4,3 @@

source "http://rubygems.org"
source "https://rubygems.org"

Copilot is powered by AI and may make mistakes. Always verify output.
Positive Feedback
Negative Feedback

Provide additional feedback

Please help us improve GitHub Copilot by sharing more details about this comment.

Please select one or more of the options
@james-ball-qualcomm
Copy link
Collaborator Author

I'm getting this Code scanning result (CodeQL) failing in the smoke test. How do we handle this? We intentionally changed from https to http.

image

@dhower-qc
Copy link
Collaborator

I think we determined this was a configuration issue with your machine. Re-open if I'm mis-remembering.

@dhower-qc dhower-qc closed this Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhower-qc dhower-qc Awaiting requested review from dhower-qc dhower-qc is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't install python into devcontainer (SSL certificate failure)
2 participants
@james-ball-qualcomm @dhower-qc