-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dockerfiles: Install the mermaid CLI #4
base: main
Are you sure you want to change the base?
Conversation
In order to include mermaid diagrams that are both github and asciidoc compatible, we need to include the mermaid-cli package. With that CLI, we can convert github mermaid diagrams on the fly, as shown in riscv-non-isa/riscv-ap-tee-io#43 Signed-off-by: Samuel Ortiz <[email protected]>
cc @rpsene |
@sameo with the version 9 we have a problem with the Chromium dependency on arm64.
|
it works with the lasted version, though. |
@rpsene Can you run |
@sameo is this the error you got? if so, this is caused given the LTS versions of npm and nodejs available on Ubuntu 22.04 are older than the one required by the latest version of mermaid. `root@ea299882b049:/build# mmdc --version SyntaxError: Unexpected token '.' When updating: I will test the updated container, if we succeed bulding the docs, I will push the update to install mermaid. |
@sameo build is OK. I will push the changes. `git diff
|
@rpsene It seems I still get the error. See: where mmdc fails with the same error you and me were seeing. Did you push your latest build? |
@sameo can you check the build result at https://github.com/riscv-non-isa/riscv-ap-tee-io/actions/runs/7128569198 I have updated the build process in that repo. |
@sameo the resolution is still pending, I hope to finish the fix by next week as I finily identified the root cause. |
In order to include mermaid diagrams that are both github and asciidoc compatible, we need to include the mermaid-cli package.
With that CLI, we can convert github mermaid diagrams on the fly, as shown in riscv-non-isa/riscv-ap-tee-io#43