src/mte_tag: revise pointer tag instructions #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current pointer tag instructions to annotate pointers with tags are zimop and take the form where `rd=0` and `rs1` acts as source and destination both. One primary feedback has been that it makes semantics weird and can impact implementation. As part of this patch, pointer tag annotation is split into two instructions. First instruction prepares the tag and second instruction merges that tag into pointer. If memory tagging is disabled then first instruction prepares zero into destination and subsequent instruction merge of tag into pointer doesn't impact addressing bits of pointer. Signed-off-by: Deepak Gupta <[email protected]>
|
Merging this PR for now as per ARC and TG direction check for revising pointer tag instructions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current pointer tag instructions to annotate pointers with tags are zimop and take the form where
rd=0andrs1acts as source and destination both. One primary feedback has been that it makes semantics weird and can impact implementation. As part of this patch, pointer tag annotation is split into two instructions. First instruction prepares the tag and second instruction merges that tag into pointer. If memory tagging is disabled then first instruction prepares zero into destination and subsequent instruction merge of tag into pointer doesn't impact addressing bits of pointer.