Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(binder): support create index statements #865

Merged
merged 4 commits into from
Jan 11, 2025
Merged

Conversation

skyzh
Copy link
Member

@skyzh skyzh commented Jan 8, 2025

part of #864

Add create index support. No indexes are created for now. It only modifies the catalog. All storage engines now use a shared submodule called index to manage in-memory indexes.

@skyzh skyzh requested a review from wangrunji0408 January 8, 2025 02:10
skyzh added 2 commits January 7, 2025 21:11
Signed-off-by: Alex Chi Z <[email protected]>
Signed-off-by: Alex Chi Z <[email protected]>
Copy link
Member

@wangrunji0408 wangrunji0408 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

src/catalog/root.rs Outdated Show resolved Hide resolved
Signed-off-by: Alex Chi <[email protected]>
@skyzh skyzh enabled auto-merge January 11, 2025 05:27
@skyzh skyzh added this pull request to the merge queue Jan 11, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 11, 2025
@skyzh skyzh added this pull request to the merge queue Jan 11, 2025
Merged via the queue into main with commit 423d0e9 Jan 11, 2025
5 checks passed
@skyzh skyzh deleted the skyzh/create-index-support branch January 11, 2025 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants