sync 03/07 #141
Merged
sync 03/07 #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Backport a bunch of upstream r8169 patches: - RTL8168/RTL8101 LEDs support. - RTL8126A support. - RTL8125/RTL8126 LEDs support. - RTL8168M support. Signed-off-by: Álvaro Fernández Rojas <[email protected]>
As reported in the following issue, this patch breaks wifi on the RPi 5. raspberrypi/linux#6237 Signed-off-by: Álvaro Fernández Rojas <[email protected]>
Marvell Amethyst switches use a different SMI GPIO pin setup than other switches, and since RB5009 uses Amethyst switch and its SMI bus to talk to QCA8081 lets backport the required fix from kernel 6.9. Link: openwrt#15765 Signed-off-by: Robert Marko <[email protected]>
QCA808x does not currently fill in the possible_interfaces. This leads to Phylink not being aware that it supports 2500Base-X as well so in cases where it is connected to a DSA switch like MV88E6393 it will limit that port to phy-mode set in the DTS. That means that if SGMII is used you are limited to 1G only while if 2500Base-X was set you are limited to 2.5G only. Populating the possible_interfaces fixes this, so lets backport the patches from kernel 6.9. This also includes a backport of the Phylink PHY validation series from kernel 6.8 that allows the use of possible_interfaces. Link: openwrt#15765 Signed-off-by: Robert Marko <[email protected]>
These need to be refreshed, probably the generic backports affected them. Link: openwrt#15765 Signed-off-by: Robert Marko <[email protected]>
MikroTik RB5009 uses Qualcomm QCA8081 PHY for the 2.5G RJ45 port, so we need to enable the driver for it. Link: openwrt#15765 Signed-off-by: Robert Marko <[email protected]>
Marvell 70x0 and 80x0 both have ARM SBSA Generic Watchdog built-in, so lets enable the required driver for them. Link: openwrt#15765 Signed-off-by: Robert Marko <[email protected]>
…erase MikroTik RB5009 will be using advantage of the MikroTik platform drivers, RouterBoot partition parser and SPI NOR variable erase support. Link: openwrt#15765 Signed-off-by: Robert Marko <[email protected]>
In order to not have to ship envtools configuration per board, we can instead rely on the kernel U-Boot environment NVMEM driver through which envtools can read/write the environement. Since size difference is negligeble and this subtarget has rather large storage regardless, enable it by default. Link: openwrt#15765 Signed-off-by: Robert Marko <[email protected]>
RB5009 will take advantage of the driver to get MAC adress. Link: openwrt#15765 Signed-off-by: Robert Marko <[email protected]>
MikroTik RB5009 uses RouterBoot as its bootloader like all MikroTik devices running RouterOS, meaning that its not FIT compatible and can only boot ELF images. Now this is not so much of an issue on ARM or MIPS since kernel supports appending DTB-s to it (Or we patch the kernel to embed it), but on ARM64 there is intentionally no such support. RouterBoot will pass a DTB, but its the broken MikroTik one which is a modified reference DTB and incorrect in more places than its valid so we cannot use it to boot our kernel. Thus, the solution is to use an intermediary loader and luckily for us Armada 7040 is well supported in U-Boot which makes it a great option since it supports anything that we will ever need to boot. Upstream U-Boot currently requires the Armada boards to be converted to OF_UPSTREAM before adding anything new and this requires updating all of the drivers to accomodate the Linux DTS, while I plan to do this eventually we will need to keep this board downstream for now. Most stuff is supported in U-Boot, including networking since the switch is preconfigured by RouterBoot. A custom environment is used to try and boot from the following devices: 1. NAND (UBI) 2. USB 3. Networking If NAND boot fails then U-Boot will attempt to boot OpenWrt initramfs from USB or via networking. There is a manual recovery mechanism implemented where if the reset button is held when U-Boot is booting it will try to boot OpenWrt initramfs from: 1. USB 2. Networking When U-Boot is in recovery mode it will light all of the LED-s except the switch ones. Link: openwrt#15765 Signed-off-by: Robert Marko <[email protected]>
This patch adds support for Mikrotik RB5009UG+S+IN. Specifications: - SoC: Marvell Armada 7040 (88F7040) - 4 cores, ARMv8 Cortex-A72, 1.4GHz, 64bit - RAM: 1024MB DDR4 - Flash: 16MB SPI NOR flash, 1024MB NAND - Ethernet: * Marvell 88E6393X - Amethyst: * one 2.5G RJ45 port via Qualcomm QCA8081 PHY * seven 1G RJ45 ports via built-in PHY-s * one 10G SFP+ cage * All ports share the same 10G switch uplink to the CPU - LED: User, SFP, Hdr1, Hdr2 - Buttons: Reset - UART: 115200 8n1 on the MikroTik 16 pin header - USB: One USB3 port - Power: 24-57 V via * DC jack * 802.3af/at PoE on Ethernet 1 * 2-pin terminal on the side 16 Pin header pinout: 1 GND Vcc RX ? GND #--------------------# |.-. .-. .-. .-. .-. | |'-' '-' '-' '-' '-' | |.-. .-. .-. .-. .-. | |'-' '-' '-' '-' '-' | #--------------------# 2 CLK DO /CS TX DI Do note that the default RouterBoot has disabled UART even when the required hard-config bit is set to indicate UART support. Patched RouterBoot must be used if UART is desired. Also, since ARM64 Linux support does not support in any way appending the DTB to the kernel image we use mainline U-Boot with added RB5009 support in order to boot OpenWrt. MikroTik uses YAFFS to store the boot kernel and we use YAFUT to put U-Boot as the kernel which RouterBoot then simply boots as an ELF. Install instructions: NOTE: In case you are using an existing out of tree version of OpenWrt make sure to reinstall RouterOS via Netinstall to return the expected partition layout. 1. Prepare FAT or EXT4 formatted USB drive with OpenWrt initramfs: * Copy bin/targets/mvebu/cortexa72/openwrt-mvebu-cortexa72-mikrotik_rb5009-initramfs-uImage.itb to the root of FAT or EXT4 formatted USB drive. * Plug in the drive to the RB5009 USB port 2. Boot the modified OpenWrt built U-Boot ELF: u-boot.elf from bin/targets/mvebu/cortexa72/u-boot-rb5009/u-boot.elf Consult OpenWrt wiki for common instructions on switching to boot from Ethernet once as well as serving the file: https://openwrt.org/toh/mikrotik/common Once U-Boot is booted it will attempt to boot in the following order: 1. NAND 2. USB 3. Network NAND is expected to fail but USB or Networking need to serve the OpenWrt initramfs image and after booting it will be accessible from LAN ports on the default 192.168.1.1 IP with default credentials. 3. Flash modified RouterBoot that enables UART (Optional but recommended): https://public.robimarko.eu/RB5009/70x0-7.15-uart.fwf * Copy the file over to the booted OpenWrt initramfs to /tmp * Run: mtd erase RouterBOOT-primary * Run: mtd write /tmp/70x0-7.15-uart.fwf RouterBOOT-primary 4. Install U-Boot to boot OpenWrt: * Copy the u-boot.elf from bin/targets/mvebu/cortexa72/u-boot-rb5009/u-boot.elf to OpenWrt initramfs to /tmp. * Run: . /lib/functions.sh * Run: yafut -d /dev/mtd$(find_mtd_index "YAFFS") -w -i /tmp/u-boot.elf -o kernel -T This will use yafut to copy the U-Boot as kernel in YAFFS so that RouterBoot boots it. 5. Wipe the NAND UBI partition: * Run: ubiformat /dev/mtd$(find_mtd_index "ubi") -y This will prepare the existing RouterOS rootfs partition for OpenWrt. 6. Flash OpenWrt: * Copy the bin/targets/mvebu/cortexa72/openwrt-mvebu-cortexa72-mikrotik_rb5009-squashfs-sysupgrade.bin to OpenWrt initramfs to /tmp. * Run: sysupgrade /tmp/openwrt-mvebu-cortexa72-mikrotik_rb5009-squashfs-sysupgrade.bin Device will reboot, boot U-Boot and then OpenWrt. Recovery: In case you need to reinstall OpenWrt if it crashes after U-Boot, there is a recovery mechanism in OpenWrt to boot the OpenWrt initramfs. You need to hold the reset button while U-Boot is booting and then it will boot the OpenWrt initramfs from: 1. USB 2. Networking In recovery mode U-Boot will light all of the LED-s except for the switch ones. In case you want to return to RouterOS, you can simply do that via Netinstall like on any other MikroTik board. Credits also go to Serhii Serhieiev <[email protected]> who origininally figured out the RouterBoot modification for UART, the missing 10G MVPP2 support in U-Boot as well as the custom aux loader to boot directly via RouterBoot. Link: openwrt#15765 Signed-off-by: Robert Marko <[email protected]>
- release notes: - https://discourse.llvm.org/t/llvm-16-0-0-release/69326 - https://discourse.llvm.org/t/llvm-17-0-1-released/73549 - https://discourse.llvm.org/t/llvm-18-1-0-released/77448 - https://discourse.llvm.org/t/llvm-18-1-1-released/77540 - https://discourse.llvm.org/t/18-1-2-released/77821 - https://discourse.llvm.org/t/18-1-3-released/78136 - https://discourse.llvm.org/t/18-1-4-released/78430 - https://discourse.llvm.org/t/18-1-5-released/78740 - https://discourse.llvm.org/t/18-1-6-released/79068 - https://discourse.llvm.org/t/18-1-7-released/79433 - remove PKG_RELEASE (irrelevant to tools) - set default target/triplet to "bpf" - rearrange configuration options - better control feature support and improve build reproducibility: disable auxiliary features that are enabled implicitly - their support is detected at build-time Signed-off-by: Konstantin Demin <[email protected]> Link: openwrt#15704 Signed-off-by: Robert Marko <[email protected]>
Backport upstream fix for incorrect ifdeffery and dependency of CONFIG_KEXEC, which causes compilation errors with the following symbols: CONFIG_CRASH_CORE=y CONFIG_KEXEC_CORE=y CONFIG_CRASH_DUMP=y Signed-off-by: Álvaro Fernández Rojas <[email protected]>
copy the 6.1 config to 6.6 Signed-off-by: Goetz Goerisch <[email protected]>
refresh 6.6. kernel patches via 'make target/linux/refresh' Signed-off-by: Goetz Goerisch <[email protected]> [refresh patches] Signed-off-by: Álvaro Fernández Rojas <[email protected]>
Refresh config for kernel 6.6. Signed-off-by: Álvaro Fernández Rojas <[email protected]>
enable testing kernel version 6.6 for bmips Signed-off-by: Goetz Goerisch <[email protected]>
Update default kernel version to 6.6 for the bmips devices. Signed-off-by: Álvaro Fernández Rojas <[email protected]>
kernel 6.1 can be dropped since 6.6 is the default kernel. Signed-off-by: Álvaro Fernández Rojas <[email protected]>
AC2400 Dual-Band Gigabit Wi-Fi Router base on ipq8064. https://www.linksys.com/support-product?sku=E8350 Specification: - Qualcomm dual-core IPQ8064 @ 1.4 GHz - 512 MB of RAM - 4 MB of SPI NOR MX25U3235F - 128 MB of NAND S34MS01G2 - Qualcomm QCA9880 2.4GHz 802.11bgn - Quantenna QSR1000 5GHz 802.11ac (no support) - 4 x 10/100/1000 Mbit/s w/ vlan support Ethernet - Qualcomm Atheros QCA8337 switch - 1 x 3.0 + 1 x 2.0 (combo with eSata port) - 115200, 8N1 internal serial console - Power, Reset, WPS and WLAN buttons - Power, WPS and WLAN leds - 12 VDC, 3 A power Installation: The installation must be done using web interface of the router. To achive this new firmware-utils tool was added to set correct magic headers for the factory images. Installation from vendor firmware: 1. Flash over the native Linksys WEB interface using factory image. Installation using recovery mode: 1. Power off the device and disconnect the WAN port. (Only LAN port to be connected) 2. Press & hold the "Reset" button 3. Power on the device & wait 10 seconds with pressed "Reset" button 4. Set IP Internet Protocol on your PC from 192.168.1.0/24 network (Router is on IP 192.168.1.1) 5. Open the Firmware Recovery page in your browser: http://192.168.1.1/index.shtml Firmware Recovery -> File Name -> Recovery & Reboot The device page in inbox: https://openwrt.org/inbox/toh/linksys/linksys_ea8350_1 Signed-off-by: Sergey Filippov <[email protected]> Link: openwrt#15798 Signed-off-by: Christian Marangi <[email protected]>
Fix broken line break for Linksys e8350-v1 pushed with CRLF instead of LF. Fixes: 45b3c62 ("ipq806x: add support for Linksys e8350-v1") Signed-off-by: Christian Marangi <[email protected]>
Backport patch for G761 PWM Fan controller support. This is used by an ipq807x RAX120v2 and have an internal clock that was currently unconfigured making the device not working. Link: openwrt#15796 Signed-off-by: Christian Marangi <[email protected]>
Fix RAX120v2 PWM Fan controller wrong definition by using a non-existant kmod and using the wrong compatible for it enabling an external clock while actually the device use an internal one. Link: openwrt#15796 Signed-off-by: Christian Marangi <[email protected]>
We have been carrying the 100-fix_includes.patch and 130-lzma_jffs2.patch for a long time but the reason is lost to history. We dont need to carry the JFFS2 LZMA support patch as mkfs.jffs2 is not even being packaged so its not even being used. As for the 100-fix_includes.patch that also seems like a relic of history as mtd-utils compiles fine without it. So, lets drop both patches. Link: openwrt#15790 Signed-off-by: Robert Marko <[email protected]>
Replace Aquantia pending LEDs patch with upstream version. Sadly net maintainers didn't like integrated solution hence we still need to handle LED restore on reset with custom solution. Link: openwrt#15797 Signed-off-by: Christian Marangi <[email protected]>
Remove unneeded default-state from led_power_green (led@4) to be in line with other bmips devices. Signed-off-by: Álvaro Fernández Rojas <[email protected]>
Remove unneeded default-state from led_power_green (led@8) to be in line with other bmips devices. Signed-off-by: Álvaro Fernández Rojas <[email protected]>
Release notes: https://lists.infradead.org/pipermail/linux-mtd/2024-March/104058.html Manually refresh the portability and JFFS2 LZMA patches. Since mtd-utils have converted most of the JFFS2 compressors to be compile time configurable and manual refreshing of JFFS2 LZMA was needed I also converted it to a compile time option and enabled the new --with-lzma option. Link: openwrt#15791 Signed-off-by: Robert Marko <[email protected]>
Passing --disable-tests does not do anything since upstream commit [0]
("Fix test binary installation") as that commit removed it since there is
already and existing --without-tests compile option to not compile
the tests at all as --disable-tests was just disabling their installation.
So, lets just pass --without-tests instead to disable test compilation.
[0] https://git.infraroot.at/mtd-utils.git/commit/?id=7170a28d46d5db1e7a9da24a5555a194a233ef0b
Fixes: 67efb6a ("tools: mtd-utils: Update to version 2.1.4")
Link: openwrt#15791
Signed-off-by: Robert Marko <[email protected]>
Adding NSS support for: Linksys MX8500 Netgear SXR80/SXS80 (SXK80 - router and satellite) Signed-off-by: Sean Khan <[email protected]>
Signed-off-by: Sean Khan <[email protected]>
1. Fix function to check for bridge master status while checking for Bridge VLAN filter feature is enabled on bridge slave ports. 2. Disable default PVID for bridges during device registration in the system. Change-Id: Ibea6559c1b0700a2300b60e20d57b7818e23a8a8 Signed-off-by: Vishnu Vardhan Bantanahal <[email protected]> bridge: Fix Bridge VLAN stats update This patch fixes Bridge VLAN stats update for both bridge master and bridge slave. Change-Id: Ia26f4c71e83e27dd83336815cda5c05c8c3f24ff Signed-off-by: Vishnu Vardhan Bantanahal <[email protected]> bridge: Add bridge VLAN filter APIs for offload for 6.1 Kernel Change-Id: I54e44c26664f86ae024f54605a032713a9a3eee5 Signed-off-by: Vishnu Vardhan Bantanahal <[email protected]> Signed-off-by: Sean Khan <[email protected]>
This patch was mostly cosmetic for ipq8074 to supress warnings about invalid memory region. In this case the M3 dump region. This isn't necessary for operation or offloading, and is used for firmware debugging. However due to the memory layout of ipq6018 it was causing issues of NSS offloading properly loading. 'idx' shouldn't be incremented, and instead should just break. Signed-off-by: Sean Khan <[email protected]>
This patch adds support for allocating 1MB of reserved memory for ramoops on IPQ807x and IPQ6018 platforms. This is required to get PSTORE option working. Tested with the following options: ``` CONFIG_PACKAGE_kmod-pstore=y CONFIG_PACKAGE_kmod-ramoops=y CONFIG_PACKAGE_kmod-reed-solomon=y ``` dmesg output ``` ➤ dmesg | grep -Ei "psto|ramo" [Sun Jun 9 23:22:01 2024] OF: reserved mem: 0x0000000051200000..0x00000000512fffff (1024 KiB) map non-reusable ramoops@51200000 [Sun Jun 9 23:22:05 2024] pstore: Using crash dump compression: deflate [Sun Jun 9 23:22:05 2024] pstore: Registered ramoops as persistent store backend [Sun Jun 9 23:22:05 2024] ramoops: using 0x100000@0x51200000, ecc: 0 ``` Triggering kernel panic ``` sh -c 'echo 10 > /proc/sys/kernel/panic; echo c > /proc/sysrq-trigger' ``` After rebooting ``` mkdir -p /tmp/ramoops mount -t pstore pstore /tmp/ramoops ``` ``` ➤ l /tmp/ramoops drwxr-x--- 2 root root 0 Jun 9 23:02 . drwxr-xr-x 8 root root 4.0K Jun 9 23:23 .. -r--r--r-- 1 root root 6.6K Jun 9 23:21 dmesg-ramoops-0 ``` Truncated output ``` Panic#1 Part1 <6>[ 21.656119] remoteproc remoteproc0: remote processor cd00000.q6v5_wcss is now up <14>[ 21.657910] kmodloader: done loading kernel modules from /etc/modules.d/* <6>[ 21.710545] ath11k c000000.wifi: chip_id 0x0 chip_family 0x0 board_id 0xff soc_id 0xffffffff <6>[ 21.710594] ath11k c000000.wifi: fw_version 0x270204a5 fw_build_timestamp 2022-08-04 13:05 fw_build_id WLAN.HK.2.7.0.1-01744-QCAHKSWPL_SILICONZ-1 <6>[ 91.416867] br-lan: topology change detected, sending tcn bpdu <6>[ 1256.023874] sysrq: Trigger a crash <0>[ 1256.023911] Kernel panic - not syncing: sysrq triggered crash <4>[ 1256.026176] CPU: 2 PID: 2842 Comm: sh Tainted: G O 6.6.32 #0 <4>[ 1256.031993] Hardware name: Linksys MX5300 (DT) <4>[ 1256.039106] Call trace: <4>[ 1256.043354] dump_backtrace+0xb0/0x10c <4>[ 1256.045701] show_stack+0x18/0x24 <4>[ 1256.049519] dump_stack_lvl+0x48/0x60 <4>[ 1256.052906] dump_stack+0x18/0x24 <4>[ 1256.056550] panic+0x2d0/0x31c <4>[ 1256.059848] sysrq_handle_moom+0x0/0x30 <4>[ 1256.062800] __handle_sysrq+0xe4/0x1e0 <4>[ 1256.066534] write_sysrq_trigger+0xbc/0xfc <4>[ 1256.070354] proc_reg_write+0xb0/0xf8 <4>[ 1256.074434] vfs_write+0xa4/0x298 <4>[ 1256.078165] ksys_write+0x5c/0xe0 <4>[ 1256.081464] __arm64_sys_write+0x1c/0x28 <4>[ 1256.084763] invoke_syscall.constprop.0+0x5c/0x100 <4>[ 1256.088758] do_el0_svc+0x40/0xc8 <4>[ 1256.093355] el0_svc+0x30/0xb8 <4>[ 1256.096740] el0t_64_sync_handler+0x120/0x12c <4>[ 1256.099694] el0t_64_sync+0x178/0x17c <2>[ 1256.104122] SMP: stopping secondary CPUs <0>[ 1256.107773] Kernel Offset: disabled <0>[ 1256.111759] CPU features: 0x0,00000000,00000000,0000400b <0>[ 1256.114975] Memory Limit: none ``` Signed-off-by: Sean Khan <[email protected]>
The following options can now be specified in `pbuf` uci config.
1.) auto_scale (bool) - enable or disable NSS CPU auto-scaling.
default: 'off'.
NOTE: Recommended to leave off, as it locks
NSS core to it's full 1.7Ghz speed. In the past
auto_scaling has been unstable, often causing
kernel panics or connection drops. Qualcomm
themselves disables scaling in QSDK for
ath11k/ath12k/qca-wifi.
It is provided to allow users wanting more
control over power usage. Setting to 'on' also
fixes NSS CPU stats updating properly.
2.) n2h_queue_limit_core0 (int) - set queue limits for CORE 0 and 1.
default: '2048'
For users on low memory systems (<=512M),
that are experiencing issues can try lowering
to the driver default of '256'.
NSS patches should always get applied last as to avoid fuzzing issues with upstream patches. Also cleanup patches that introduced spaces as indents vs. tabs Signed-off-by: Sean Khan <[email protected]> ath11k_nss: drop upstreamed patch A variation of this patch 'wifi: mac80211: Use flexible array in struct ieee80211_tim_ie' was upstreamed in commit 'e6e4d90b69027d74ba7e9a0a586b95a5714e10c0'. Remove it to avoid compilation issues. Signed-off-by: Sean Khan <[email protected]> ath11k_nss: Fix patch conflict Signed-off-by: Sean Khan <[email protected]>
Signed-off-by: Sean Khan <[email protected]>
Signed-off-by: Sean Khan <[email protected]>
Add wake_tx_queue mac op to support AQL and support txq dequeueing from mac80211. Also implement a simple scheduler for pulling all skbs from txqs of all AC's at the end of tx completion NAPI. Tested-on: IPQ5018 hw1.0 AHB WLAN.HK.2.6.0.1-00861-QCAHKSWPL_SILICONZ-1 Signed-off-by: Tamizh Chelvam Raja <[email protected]> Signed-off-by: Sean Khan <[email protected]>
Revert to using the default kernel timer (CONFIG_HZ_100). Setting the timer to 1000hz is unecessary and just adds CPU overhead. It also causes atomic scheduling issues in various threaded tasks, especially when using threaded NAPI. When the kernel timer frequency is set to 1000 Hz, it generates interrupts 1000 times per second. This increased frequency can lead to more frequent context switches and interrupt handling, which can interfere with other kernel activities. Since network packet processing is offloaded to the NSS cores, the main CPU does not need high-resolution timer interrupts to manage network traffic efficiently. The NSS cores handle this independently. This is the setting used and recommended by Qualcomm for all their IPQ platforms. Signed-off-by: Sean Khan <[email protected]>
https://cdn.kernel.org/pub/linux/kernel/v6.x/ChangeLog-6.6.36 Fix patch: generic/hack-6.6/765-mxl-gpy-control-LED-reg-from-DT.patch Refreshed: generic/hack-6.6/790-SFP-GE-T-ignore-TX_FAULT.patch generic/hack-6.6/810-bcma-ssb-fallback-sprom.patch generic/hack-6.6/902-debloat_proc.patch generic/pending-6.6/600-netfilter_conntrack_flush.patch generic/pending-6.6/630-packet_socket_type.patch generic/pending-6.6/670-ipv6-allow-rejecting-with-source-address-failed-policy.patch qualcommax/patches-6.6/0600-1-qca-nss-ecm-support-CORE.patch qualcommax/patches-6.6/0600-7-qca-nss-ecm-fix-IPv6-user-route-change-event-calls.patch qualcommax/patches-6.6/0603-1-qca-nss-clients-add-qdisc-support.patch qualcommax/patches-6.6/9990-1-qca-skb_recycler-support.patch Signed-off-by: Sean Khan <[email protected]>
Cleaned up erronous settings for disabled features. The syntax should be "# CONFIG_SOME_OPTION is not set", rather than simply commenting it out. Removed left over config options from 5.15, and enabled features recommended by QSDK: ``` CONFIG_IRQ_TIME_ACCOUNTING=y CONFIG_MULTI_IRQ_HANDLER=y CONFIG_HANDLE_DOMAIN_IRQ=y CONFIG_HZ_FIXED=0 CONFIG_NO_HZ=y ``` Signed-off-by: Sean Khan <[email protected]>
Signed-off-by: Sean Khan <[email protected]>
Signed-off-by: Sean Khan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for your contribution to OpenWrt!
To help keep the codebase consistent and readable,
and to help people review your contribution,
we ask you to follow the rules you find in the wiki at this link
https://openwrt.org/submitting-patches
Please remove this message before posting the pull request.