Massive changes in fork - would like you to be aware #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@robby-cornelissen I just wanted to make you at least aware of my fork. This is an absolutely wonderful project of yours, so thank you SO much for it!
I forked this last year to try and get it working with modern
pybluez2... and then fell down a pretty big rabbit hole of refactoring into a class and Python package and then also into a reusable library, adding logging and argparse, replacingsys.exitcalls with exceptions, printing multiple labels, USB support, and then adding a second command-line entrypoint for rendering specified text on a label, including rotated or rotated-repeated text, and then also adding Code128 barcode support.I know this has really gotten quite far diverged from your repo, but figured that before I do any more work on this, I should ask if you'd have any interest in me reconciling my fork with the latest changes in your repo, and maybe contributing these changes back?