Pattern match rest as #6030
Merged
Pattern match rest as #6030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhansconnect
force-pushed
the
pattern-match-rest-as
branch
from
b2c5b0f to
8caa03b
Compare
bhansconnect
force-pushed
the
pattern-match-rest-as
branch
from
c40765b to
e3174f6
Compare
bhansconnect
force-pushed
the
pattern-match-rest-as
branch
from
cd387f5 to
2ef97fc
Compare
ayazhafiz
reviewed
Nov 21, 2023
| element_layout: InLayout<'a>, | ||
| elements: &[Pattern<'a>], | ||
| opt_rest: &Option<(usize, Option<Symbol>)>, |
There was a problem hiding this comment.
(usize, None) does happen higher up in the ast if we have a spread that doesn't capture (at least that is my assumption, didn't double check the code the code) (double checked, yeah, that happens and matter higher up the stack).
Originally I had it converting to Option<(usize, Symbol)> cause mono only cares about it if the symbol exists.
I removed it cause it felt unnecessary to have two checks. One to go to this other format and one in mono to decide if we should generate the the binding for rest. I can change it back to that if you want.
There was a problem hiding this comment.
Ah gotcha. Makes sense. No need to change i think
ayazhafiz
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still need to add some tests, but seems to be working!
Fixes #5187