Add log function to Dec
#6090
Merged
Add log function to Dec
#6090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -463,6 +463,10 @@ pub const RocDec = extern struct { | |||
| return RocDec{ .num = out }; | |||
| } | |||
|
|
|||
| pub fn log(self: RocDec) RocDec { | |||
| return fromF64(@log(self.toF64())).?; | |||
There was a problem hiding this comment.
Not necessary for this PR, but I just realized that we should probably have a version of fromF64 that just calls roc_panic if it fails instead of generating a zig orelse unreachable. If this happens, we either should properly panic or potentially recover in the log and similar functions.
bhansconnect
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was achieved in a similar manner as other mathematical functions, such as
asin.This closes #5830.