Automatic annotation of type signatures #7130
Conversation
snobee
force-pushed
the
annotate-type-signatures
branch
4 times, most recently
from
f03b305 to
387c509
Compare
| buffer | ||
| } | ||
|
|
||
| pub fn annotation_edits( |
There was a problem hiding this comment.
I've exposed this and annotations_edit() publicly to be used in the language server but It feels weird to expose them from the cli crate. If it should be in another crate what one?
crates/cli/src/main.rs
Outdated
|
|
||
| let annotate_exit_code = match annotate_file(&arena, roc_file_path.to_owned()) { | ||
| Ok(()) => 0, | ||
| Err(LoadingProblem::FormattedReport(report)) => { |
There was a problem hiding this comment.
If there's a problem loading the file then it just prints out the error. I know this needs to be updated but I'm not sure what the error message should be. Should it include the loading problem or just say that there was one?
|
I've added some comments on the code with some questions about things that I'm not sure about
|
|
Thank you for your contribution! Sometimes PRs end up staying open for a long time without activity, which can make the list of open PRs get long and time-consuming to review. To keep things manageable for reviewers, this bot automatically closes PRs that haven’t had activity in 60 days. This PR hasn’t had activity in 30 days, so it will be automatically closed if there is no more activity in the next 30 days. Keep in mind that PRs marked |
snobee
force-pushed
the
annotate-type-signatures
branch
from
387c509 to
acea61b
Compare
|
This has been open long enough so I've put it up for review. There's still issues with suffixed expressions from #7126 but the code for this is independent from that. |
snobee
force-pushed
the
annotate-type-signatures
branch
from
acea61b to
d4e558d
Compare
|
I changed an if to an assert last minute 🙃. That should fix it |
|
@snobee -- can you please merge latest main? Apologies for leaving it so long... I think this slipped through and got forgotten about. |
Resolves #7042
I've started with all the logic in analysed_doc but I'll probably end up moving some of it into fmt when I start on that part
I'm making some assumptions here that I wanted to confirm: