add: buildRocPackage lib output to nix flake #7391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anton-4
requested changes
Dec 31, 2024
nxy7
commented
Dec 31, 2024
| @@ -0,0 +1,41 @@ | |||
| { pkgs, roc-cli, name, entryPoint, src, outputHash, linker ? "", ... }: | |||
There was a problem hiding this comment.
Right now this depends on passed in roc-cli. I think it's fine until roc is in nixpkgs, then we could just use roc-cli from pkgs.
Anton-4
previously approved these changes
Dec 31, 2024
|
@Anton-4 -- I also update the flake and resolved the nix deprecation warnings. |
Were these shown on your machine only? |
|
I upgraded my nix version to |
Anton-4
reviewed
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
buildRocPackagefunction as output of flake lib which allows packaging Roc apps using Nix.Here's how usage of
buildRocPackagelooks like from remote flake.Probably it can be improved, but it was sufficient to package
roc-startand should be okay starting point.Screenshot of
roc-startpackaged usingbuildRocPackage