Skip to content

Commit

Permalink
fix ErrorBoundary fallbackUI prop type definition (#95)
Browse files Browse the repository at this point in the history
* fix: fix ErrorBoundary fallbackUI prop

* update type using ComponentType and use PropTypes.elementType for runtime type

* use ComponentType import

---------

Co-authored-by: Daniel Fry <[email protected]>
  • Loading branch information
danfry1 and daniel-encord authored Jun 20, 2023
1 parent 6c506a2 commit 12e260d
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions index.d.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { Component, Context as ReactContext, ErrorInfo, ReactNode } from 'react';
import { Component, Context as ReactContext, ErrorInfo, ReactNode, ComponentType } from 'react';
import Rollbar, { Callback, Configuration } from 'rollbar';

export const LEVEL_DEBUG = 'debug';
Expand All @@ -16,7 +16,7 @@ export type LEVEL =
type Extra = Record<string | number, unknown>;
export interface ErrorBoundaryProps {
children: ReactNode;
fallbackUI?: ReactNode;
fallbackUI?: ComponentType<{ error: Error | null, resetError: () => void }>;
errorMessage?: string | (() => string);
extra?:
| Extra
Expand Down
2 changes: 1 addition & 1 deletion src/error-boundary.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ export class ErrorBoundary extends Component {
static contextType = Context;

static propTypes = {
fallbackUI: PropTypes.func,
fallbackUI: PropTypes.elementType,
errorMessage: PropTypes.oneOfType([PropTypes.string, PropTypes.func]),
extra: PropTypes.oneOfType([PropTypes.object, PropTypes.func]),
level: PropTypes.oneOfType([PropTypes.string, PropTypes.func]),
Expand Down

0 comments on commit 12e260d

Please sign in to comment.